Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]:Added hover effect to Supporters Cards #414

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

coder12git
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Added hover effects to the Supporters cards on the website. This enhancement would improve the user experience and provide visual feedback when interacting with the cards.

  • What is the current behavior? (You can also link to an open issue here)

Issue -> #412
Currently, the cards on the website do not exhibit any visual change when hovered over. This can make the user interface feel static and less engaging.

  • What is the new behavior (if this is a feature change)?

When a user hovers over a card, it would display a subtle hover effect to indicate interactivity. This would include changing the background color, and adding a border.

Loom.Message.-.21.August.2023.mp4
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No changes.

  • Other information:
    By implementing this hover effect, we can enhance the user experience and make the website's interface more dynamic and engaging.

@kubeedge-bot
Copy link
Collaborator

Welcome @coder12git! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2023
@coder12git
Copy link
Contributor Author

Hey @fisherxu please review my PR.

@@ -2,7 +2,7 @@ import React from "react";
import SectionContainer from "../sectionContainer";
import Translate from "@docusaurus/Translate";
import "./index.scss";

import Link from "@docusaurus/Link";
const supportList = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coder12git Thank you for your contributions! I think adding a blank line here between import and following parts would make the format look better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coder12git Thank you for your contributions! I think adding a blank line here between import and following parts would make the format look better.

Done @Shelley-BaoYue

@coder12git
Copy link
Contributor Author

Also @Shelley-BaoYue I want to inform you that I am looking forwared to contribute to this issue - #347, under LFX Fall'23. I have already submitted my application for this. I would love to get involved with this project and make and look forward to making an amazing contribution!

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coder12git Please squash the commits to fix the failed DCO test, thanks.

Signed-off-by: Suruchi Kumari <[email protected]>
Signed-off-by: Suruchi Kumari <[email protected]>
@coder12git
Copy link
Contributor Author

@coder12git Please squash the commits to fix the failed DCO test, thanks.

Done

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @Shelley-BaoYue

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@Shelley-BaoYue
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@kubeedge-bot kubeedge-bot merged commit 34e02b3 into kubeedge:master Aug 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants