Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update container runtime docs #474

Merged
merged 1 commit into from
Jan 31, 2024
Merged

update container runtime docs #474

merged 1 commit into from
Jan 31, 2024

Conversation

Shelley-BaoYue
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue commented Dec 6, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

docs update

  • What is the current behavior? (You can also link to an open issue here)

The container runtime docs is outdated, which can cause confusion and difficulties for users.

#433

  • What is the new behavior (if this is a feature change)?

Update this container runtime

https://deploy-preview-474--competent-hypatia-4195b7.netlify.app/docs/setup/prerequisites/runtime
https://deploy-preview-474--competent-hypatia-4195b7.netlify.app/zh/docs/setup/prerequisites/runtime

@Shelley-BaoYue
update container runtime docs
0ad40f9 
Signed-off-by: Shelley-BaoYue <[email protected]>
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2023
@Shelley-BaoYue Shelley-BaoYue mentioned this pull request Dec 6, 2023
Open
8 tasks
@Shelley-BaoYue
Copy link
Collaborator Author

PTAL @fisherxu @WillardHu @ZhengXinwei-F @luomengY @wbc6080

@ZhengXinwei-F
Copy link

lgtm

fisherxu
fisherxu reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @WillardHu

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@WillardHu
Copy link
Contributor

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@kubeedge-bot kubeedge-bot merged commit fa18fc4 into kubeedge:master Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@dingyin dingyin Awaiting requested review from dingyin

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@WillardHu WillardHu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shelley-BaoYue @ZhengXinwei-F @kubeedge-bot @WillardHu @fisherxu