Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of kubeedge deployment documentation: Handling issues with insufficient edge node resources for normal deployment. #551

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

hyp4293
Copy link

@hyp4293 hyp4293 commented May 22, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...
    docs update,

  • What is the current behavior? (You can also link to an open issue here)

Optimization of kubeedge deployment documentation: Handling issues with insufficient edge node resources for normal deployment. By applying appropriate labels, prevent certain applications from extending to edge nodes, thereby conserving edge node resources and alleviating resource pressure on the nodes.

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dingyin after the PR has been reviewed.
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Collaborator

Welcome @hyp4293! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2024
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using English in PR title and description is more friendly in an open source community.

docs/setup/install-with-keadm.md Outdated Show resolved Hide resolved
In the case of insufficient qualifications for edge nodes, we need to label them to prevent some applications from extending to edge nodes.

```
kubectl get daemonset -n kube-system |grep -v NAME |awk '{print $1}' | xargs -n 1 kubectl patch daemonset -n kube-system --type='json' -p='[{"op": "replace","path": "/spec/template/spec/affinity","value":{"nodeAffinity":{"requiredDuringSchedulingIgnoredDuringExecution":{"nodeSelectorTerms":[{"matchExpressions":[{"key":"node-role.kubernetes.io/edge","operator":"DoesNotExist"}]}]}}}}]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubeedge/website/pull/551/files#diff-58f39633768f7241615b445ab20cf0842acb0f0f38597ca61e8c4afceeeac56fR308 has a similar description, we need to let users know that kube-proxy and some others is not required at the edge

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will remind users that kube-proxy and some other components are not required at the edge. They can handle it accordingly.


```

Any daemonset cannot occupy the hardware resources of edge nodes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is too radical.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is indeed too abrupt; we will make modifications.

@hyp4293
Copy link
Author

hyp4293 commented May 23, 2024

Using English in PR title and description is more friendly in an open source community.

We will use English in PR title and description

…th insufficient edge node resources for normal deployment.
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2024
@hyp4293 hyp4293 changed the title kubeedge部署文档内容优化:边缘节点资源紧张无法正常部署的问题处理 Optimization of kubeedge deployment documentation: Handling issues with insufficient edge node resources for normal deployment. May 23, 2024
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2024
@fisherxu
Copy link
Member

Plz use English in commit message, thanks.

@@ -0,0 +1,156 @@
# KubeEdge 镜像预加载功能指导文档
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push a separate PR to add imapePrepull guide. And it belongs to docs but not blog. A English version is also needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have resubmitted as requested

@Shelley-BaoYue
Copy link
Collaborator

DCO failed, it need to be processed, you need add -s when you add a commit. Click the details to see how to solve it
image

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2024
@kubeedge-bot
Copy link
Collaborator

@hyp4293: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1Shubham7 and others added 8 commits July 6, 2024 20:22
Signed-off-by: GitHub <[email protected]>
Signed-off-by: hyp4293 <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: hyp4293 <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: hyp4293 <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: hyp4293 <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: hyp4293 <[email protected]>
Signed-off-by: fisherxu <[email protected]>
Signed-off-by: hyp4293 <[email protected]>
…th insufficient edge node resources for normal deployment.

Signed-off-by: hyp4293 <[email protected]>
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants