Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeedge Local Up Scirpt Guide #600

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

xuemingdi
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:
#433

Fixes #

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs update

  • What is the current behavior? (You can also link to an open issue here)
    N.A

  • What is the new behavior (if this is a feature change)?
    Add Kubeedge Local Upgrade Scirpt Guide
    Umbrella Issue for KubeEdge Documentation Improvement #433

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2024
@xuemingdi xuemingdi changed the title Kubeedge Local Upgrade Scirpt Guide Kubeedge Local Up Scirpt Guide Aug 4, 2024
@xuemingdi
Copy link
Contributor Author

This pr is to add a script guide for Kubeedge local up which requested in: #433

Comment on lines 49 to 47
5. Shutting Down the Cluster:
If the cluster is no longer needed, you can use the cleanup function provided in the script to stop and clean up the cluster and related resources.

```shell
cleanup
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a note: Users can directly use ctrl+c to terminate the script and call the cleanup function to clean up the environment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified shutting down parts.

Comment on lines +82 to +79

3. Container Runtime Installation:

Based on the user's choice of container runtime (docker, cri-o, isulad), the script attempts to install the corresponding runtime tools.
Checks and verifies the installation of Go language version, kubectl tool, and kind tool.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to mention here that if the user does not set the container runtime, we will use containerd by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add note that containerd will be set by default.

Comment on lines 36 to 39
```shell
healthcheck
kubectl get nodes | grep edge-node | grep -q -w Ready && break
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, healthcheck is generally only used inside scripts. Users can directly check the kubeedge node status through the k8s API, so I recommend deleting healthcheck here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed that part in the usage steps, and mentioned in the script analysis that user could use k8s API to check the health status.

Comment on lines 28 to 30
```shell
hack/local_up_kubeedge.sh
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of script is local-up-kubeedge.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the script name


1. Set environment variables

This script sets several environment variables at the beginning, including log directory, log level, timeout duration, protocol type, container runtime type, Kebenetes cluster name and etc. This is the necessary for local Kebeedge cluster setting up and starting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This script sets several environment variables at the beginning, including log directory, log level, timeout duration, protocol type, container runtime type, Kebenetes cluster name and etc. This is the necessary for local Kebeedge cluster setting up and starting.
This script sets several environment variables at the beginning, including log directory, log level, timeout duration, protocol type, container runtime type, Kubernetes cluster name and etc. This is the necessary for local KubeEdge cluster setting up and starting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the name

Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@@ -0,0 +1,170 @@
---
title: Kubeedge Local Up
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Kubeedge Local Up
title: KubeEdge Local Up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified.

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shelley-BaoYue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@kubeedge-bot kubeedge-bot merged commit 6c30976 into kubeedge:master Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants