Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated footer year #668

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Automated footer year #668

wants to merge 4 commits into from

Conversation

vickybesra
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #597

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@fujitatomoya fujitatomoya mentioned this pull request Jan 23, 2025
Closed
3 tasks
fujitatomoya
fujitatomoya reviewed Jan 23, 2025
View reviewed changes
docusaurus.config.js Outdated
const currentYear = new Date().getFullYear();
const localizedCopyrights = {
en: `${currentYear} © KubeEdge Project Authors. All rights reserved.`,
zh: `${currentYear} © KubeEdge 项目作者。版权所有。`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have this Chinese version of footer in here? i think this is meant to be English version only, so i think it works okay with current implementation.

i18n/zh/docusaurus-theme-classic/footer.json Outdated
@@ -1,6 +1,6 @@
{
"copyright": {
"message": "2024 © KubeEdge Project Authors. All rights reserved.",
"message": "2025 © KubeEdge Project Authors. All rights reserved.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO #597 requires avoiding this update with auto-generated year, so statically putting the year here is not really what #597 wants?

@vickybesra
Copy link
Author

I am not sure how to automate the copyright in (https://github.com/kubeedge/website/blob/master/i18n/zh/docusaurus-theme-classic/footer.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@anvithks anvithks Awaiting requested review from anvithks

@dingyin dingyin Awaiting requested review from dingyin

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-Generate Year for Chinese Pages
3 participants
@vickybesra @kubeedge-bot @fujitatomoya