Skip to content
This repository was archived by the owner on Sep 12, 2023. It is now read-only.

modify comment error #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
modify comment error
  • Loading branch information
TonyZZhang committed Mar 23, 2023
commit 17dc547c133298334a8f8c3a92b7536078540456
3 changes: 1 addition & 2 deletions pkg/controller.v1/common/pod.go
Original file line number Diff line number Diff line change
@@ -271,7 +271,7 @@ func (jc *JobController) ReconcilePods(
rType apiv1.ReplicaType,
spec *apiv1.ReplicaSpec,
replicas map[apiv1.ReplicaType]*apiv1.ReplicaSpec) error {

// Convert ReplicaType to lower string.
rt := strings.ToLower(string(rType))
metaObject, ok := job.(metav1.Object)
if !ok {
@@ -288,7 +288,6 @@ func (jc *JobController) ReconcilePods(
}
expectationPodsKey := expectation.GenExpectationPodsKey(jobKey, rt)

// Convert ReplicaType to lower string.
logger := commonutil.LoggerForReplica(metaObject, rt)
// Get all pods for the type rt.
pods, err = jc.FilterPodsForReplicaType(pods, rt)