feat: allow users to set a relative path to save compiled Pipeline DSL by Ya-shh · Pull Request #646 · kubeflow/kale

Ya-shh · 2026-02-28T17:37:38Z

By default, Kale saves the generated KFP DSL script to a hidden .kale/ folder, making it hard for users to find.

This PR adds an Output Directory field to the Kale panel in JupyterLab, letting users specify where the compiled pipeline file should be saved (e.g. pipelines/output).

The same option is available via the --output_path CLI flag.

Leaving the field empty preserves the existing .kale/ default.

Closes #630

google-oss-prow · 2026-02-28T17:37:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yash <yashh.real@gmail.com>

Ya-shh · 2026-02-28T17:41:04Z

Fixes! - #630

ada333 · 2026-03-02T15:22:35Z

Thank you for working on this @Ya-shh ! The functionality works as expected and the code looks good. Only thing I would change is the error message when putting in invalid path:

With that I would also add some invalid paths to the tests. (absolute paths, paths with .. , etc.)

Please let me know if you agree.

Ya-shh · 2026-03-04T15:39:54Z

Thank you for working on this @Ya-shh ! The functionality works as expected and the code looks good. Only thing I would change is the error message when putting in invalid path:
With that I would also add some invalid paths to the tests. (absolute paths, paths with .. , etc.)
Please let me know if you agree.

Hey @ada333 , thanks for the review !
Do you want to update the error 'Message:' description to something more detailed, like:
'/* is not a valid output directory. Please use a relative path'?

ada333 · 2026-03-04T15:56:14Z

@Ya-shh yes exactly!

Signed-off-by: Yash <yashh.real@gmail.com>

Ya-shh · 2026-03-04T15:59:56Z

@Ya-shh yes exactly!

Thanks @ada333 , I have pushed the changes, please take a look

ada333

@Ya-shh works as expected, code looks good to me, great that you added tests with the new feature. Thanks!

Ya-shh · 2026-03-13T11:00:20Z

I have resolved the merge conflicts

jesuino

Thanks again for your contribution. I am suggesting another way to check the path set by the user. Does that make sense? Please also let me know if you think that this could be set using settings - if that's the case we can open an issue later to make it configurable from the client side as well.

Thanks!

jesuino · 2026-03-18T02:07:04Z

kale/config/validators.py

+    def _validate(self, value: str):
+        if not value:
+            return
+        if os.path.isabs(value):


Have you tried to:

Resolve the user path using Path.resolve(); Notice that when you call resolve you will have as result the actual path, not symlinks or shortcuts (such as ..)

Make it sure that it relative to the target directory, seomthing like: user_path.startswith(project_dir) - this way we ensure that the path is only set relative to the project path and not anywhere else on the disk

Does that make sense to you?

…-output-path # Conflicts: # kale/tests/unit_tests/test_output_path.py

Ya-shh · 2026-03-18T17:11:27Z

@jesuino Thanks a lot for the review !, I have replaced the string based checks with Path.resolve() + startswith(project_dir) as you suggested. One check now covers absolute paths, .. traversal, and symlinks.

jesuino

Hello @Ya-shh

Thanks again for your changes. I did test and it is working perfectly. There's just one point which is the UI for the input path being on the LeftPane. This is better suitable to be a part of Jupyter Lab settings, see this PR by @alikhere . Once yours and theirs PR is merged we should create an issue to move this configuration to the settings.

Ya-shh · 2026-03-25T09:50:22Z

Hello @Ya-shh

Thanks again for your changes. I did test and it is working perfectly. There's just one point which is the UI for the input path being on the LeftPane. This is better suitable to be a part of Jupyter Lab settings, see this PR by @alikhere . Once yours and theirs PR is merged we should create an issue to move this configuration to the settings.

Yes it is better suited there, but personally I find it more useful to have the path directly in the LeftPane, I think it's easier to navigate from there

jesuino · 2026-03-26T23:12:13Z

Hello @Ya-shh

I prefer the Settings because I do believe that the Left Pane should have only Pipeline related configuration, but I do understand your point. I asked this on the community, feel free to participate there:

https://cloud-native.slack.com/archives/C08KJBVDH5H/p1774566643127079

Ya-shh · 2026-03-28T11:47:06Z

Hey @jesuino in my opinion we should go with Settings as you said .However ,it would be good to make the resolved output path visible somewhere lightweight on the Left Pane, like a small read only label or tooltip near the compile/deploy button (e.g., "Output: .kale/").
That way:

The Left Pane stays clean and pipeline focused
Power users know where to configure it i.e in Settings
Users can still see where output goes without digging

jesuino · 2026-03-30T15:09:49Z

Hello @Ya-shh

The settings PR has been merged. Would you please make the changes to support the output path in Settings?

Thanks!

jesuino · 2026-04-09T17:02:49Z

Hello @Ya-shh

Just to check if you are still working on this. If you are busy or don't want to work on this anymore please let us know.

Thanks!

Ya-shh · 2026-04-09T17:27:45Z

Hey @jesuino, I will work on this. I was quite busy last week, but I have already planned out the code. Please wait, I will try to complete this by the end of the week

google-oss-prow bot requested review from StefanoFioravanzo and ederign February 28, 2026 17:37

google-oss-prow bot added the size/L label Feb 28, 2026

feat: allow users to set a relative path to save compiled Pipeline DSL

5811c54

Signed-off-by: Yash <yashh.real@gmail.com>

Ya-shh force-pushed the feat/configurable-dsl-output-path branch from 40b7766 to 5811c54 Compare February 28, 2026 17:38

feat: add output path validation

41fb34f

Signed-off-by: Yash <yashh.real@gmail.com>

ada333 approved these changes Mar 4, 2026

View reviewed changes

google-oss-prow bot assigned ada333 Mar 4, 2026

google-oss-prow bot added the lgtm label Mar 4, 2026

google-oss-prow bot removed the lgtm label Mar 13, 2026

jesuino suggested changes Mar 18, 2026

View reviewed changes

google-oss-prow bot assigned jesuino Mar 18, 2026

Merge remote-tracking branch 'origin/main' into feat/configurable-dsl…

789cae2

…-output-path # Conflicts: # kale/tests/unit_tests/test_output_path.py

Ya-shh force-pushed the feat/configurable-dsl-output-path branch from 1ce7658 to 789cae2 Compare March 18, 2026 17:09

Ya-shh added 2 commits March 18, 2026 22:41

Merge branch 'main' into feat/configurable-dsl-output-path

b9e07df

Merge branch 'main' into feat/configurable-dsl-output-path

926093a

jesuino approved these changes Mar 23, 2026

View reviewed changes

google-oss-prow bot added the lgtm label Mar 23, 2026

Conversation

Ya-shh commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-prow bot commented Feb 28, 2026

Uh oh!

Ya-shh commented Feb 28, 2026

Uh oh!

ada333 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ya-shh commented Mar 4, 2026

Uh oh!

ada333 commented Mar 4, 2026

Uh oh!

Ya-shh commented Mar 4, 2026

Uh oh!

ada333 left a comment

Choose a reason for hiding this comment

Uh oh!

Ya-shh commented Mar 13, 2026

Uh oh!

jesuino left a comment

Choose a reason for hiding this comment

Uh oh!

jesuino Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Ya-shh commented Mar 18, 2026

Uh oh!

jesuino left a comment

Choose a reason for hiding this comment

Uh oh!

Ya-shh commented Mar 25, 2026

Uh oh!

jesuino commented Mar 26, 2026

Uh oh!

Ya-shh commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesuino commented Mar 30, 2026

Uh oh!

jesuino commented Apr 9, 2026

Uh oh!

Ya-shh commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ya-shh commented Feb 28, 2026 •

edited

Loading

ada333 commented Mar 2, 2026 •

edited

Loading

Ya-shh commented Mar 28, 2026 •

edited

Loading