issue 680: configure kale to use different kfp server#702
issue 680: configure kale to use different kfp server#702hmtosi wants to merge 32 commits intokubeflow:mainfrom
kale to use different kfp server#702Conversation
Signed-off-by: Hannah Tosi <htosi@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
jesuino
left a comment
There was a problem hiding this comment.
Hello Hannah,
Thanks for your PR, it seems that everything is on place for allowing us to make a fine configuration of the kfp.Client() creation!
I mentioned another place where the kfp.Client is called, would you please check my comment and let me know your thoughts?
Thanks!
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: William Siqueira <william.fatecsjc@gmail.com>
Fix circular import
jesuino
left a comment
There was a problem hiding this comment.
It is looking great and working well locally! I just have one final solution.
Thanks!
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
|
@ederign @StefanoFioravanzo this is ready for your final review/approval when you have a moment, thank you! |
|
/hold I'll need some time to review this one |
|
New changes are detected. LGTM label has been removed. |
…ime) Signed-off-by: Hannah Tosi <htosi@redhat.com>
Signed-off-by: Hannah Tosi <htosi@redhat.com>
|
Hi @ada333 @jesuino, this is ready for review again. I have made some changes to the authentication security so that...
I did the following checks on my local kale installation: ✅ Verify that Kale is available ✅ Run a pipeline ✅ Assign new from kale.config import kfp_server_config
kfp_server_config.save_config({"host": "http://localhost:8081"})-this saves successfully, and then the KFP connectivity check shows that KFP is suddenly unreachable ✅ Try to assign new kfp_server_config.save_config(
{
"auth_type": "dex",
"auth_config": {"cookies": "session=abc"}, # ← Should fail
}-this fails with ✅ Assign new kfp_server_config.save_config(
{
"auth_type": "existing_bearer_token",
"auth_config": {"env_var": "KF_PIPELINES_TOKEN"}, # ← Should pass
}-this succeeds with the message Further functionality will be added with the UI ticket. One known issue is that running the |
Closes #680
This is the backend ticket only.
UI will be addressed in #713
Testing
Quick Manual Check
kfpserver on a known port (default is 8080)kaleextension and start JupyterLabKaletab, verify that KFP connection status isConnected[Note] - Any of the six configuration parameters can be adjusted in this way - any parameters you do not adjust will remain as the default
Disconnected(you may need to refresh JupyterLab)kfp_server_config.jsonfile on your local machine (it should be athome/.kale/kfp_server_config.json), and make sure it has been modified with the latest changes.Unit Test
In development