Skip to content

docs: comprehensive code documentation for contributor onboarding#712

Open
nameershah wants to merge 3 commits intokubeflow:mainfrom
nameershah:docs/comprehensive-fix
Open

docs: comprehensive code documentation for contributor onboarding#712
nameershah wants to merge 3 commits intokubeflow:mainfrom
nameershah:docs/comprehensive-fix

Conversation

@nameershah
Copy link
Copy Markdown

Consolidating marshalling, step, and transformer documentation into a single signed-off PR.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nameershah
Copy link
Copy Markdown
Author

@ada333 Should PR #712 merge before I submit my GSoC proposal, or is the scope already captured in my proposal timeline?

@ada333
Copy link
Copy Markdown
Collaborator

ada333 commented Mar 19, 2026

@nameershah I have no idea, sorry 😃
But I would guess it will be in your proposal timeline

Copy link
Copy Markdown
Collaborator

@ada333 ada333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please sign-off your commits the DCO fails.

Added a default execution handler for Steps without a registered pipeline, including logging and error handling.

Signed-off-by: Muhammad Nameer Shah <190166225+nameershah@users.noreply.github.com>
Signed-off-by: Muhammad Nameer Shah <nameershah@users.noreply.github.com>
Added detailed docstring for the main entry point of the Kale KFServing Transformer server, including usage and argument descriptions.

Signed-off-by: Muhammad Nameer Shah <190166225+nameershah@users.noreply.github.com>
Signed-off-by: Muhammad Nameer Shah <nameershah@users.noreply.github.com>
Signed-off-by: Muhammad Nameer Shah <smns3960@gmail.com>

Signed-off-by: Muhammad Nameer Shah <nameershah@users.noreply.github.com>
@nameershah nameershah force-pushed the docs/comprehensive-fix branch from bc919b9 to 8bc49c7 Compare March 26, 2026 10:02
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 26, 2026
@nameershah
Copy link
Copy Markdown
Author

Hi @ada333, I've fixed the DCO by signing off all commits. Could you re-approve when you get a chance? Thank you!

@google-oss-prow google-oss-prow bot added the lgtm label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants