ISSUE-648: Change status classes to functional components#722
ISSUE-648: Change status classes to functional components#722ada333 wants to merge 2 commits intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jesuino
left a comment
There was a problem hiding this comment.
Hello Adam,
Thanks for your work on this, I checked the other PR and it is looking good! Would it be possible to do all work in a single PR? It will even better for your to work on a single PR because when you get to dependent components you may have weird behavior related to state mismatch.
Thanks!
| @@ -14,33 +14,34 @@ | |||
|
|
|||
| import * as React from 'react'; | |||
| // import { CSSProperties } from 'jss/css'; | |||
There was a problem hiding this comment.
Can we take this opportunity to remove unused comments?
c032b97 to
670b8e4
Compare
Signed-off-by: Adam Maly <amaly@redhat.com>
Signed-off-by: Adam Maly <amaly@redhat.com>
#648
This PR refactors these classes into functional components:
For better code quality and readability there were some new hooks and separate component files added:
New hooks:
New dialog components (extracted from CellMetadataEditor):
Other cleanup:
Left Panel will be refactored in another PR.
TESTING:
To test this I spinned up jupyter lab with these changes and jupyter lab from main and I compared the behaviour of UI. I recommend for testing of this PR to do the same thing.