Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

[WIP] Dex Plugin #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

krishnadurai
Copy link
Contributor

@krishnadurai krishnadurai commented Dec 10, 2019

Still work in progress. DO NOT REVIEW.


This change is Reviewable

Implements StaticUserAuth Spec for Dex
Sets the above as a secret in kubeflow namespace

TODO(krishnadurai): Use secret in Dex manifests and put this in auth NS
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kunmingg
You can assign the PR to them by writing /assign @kunmingg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Removes unused constants in platform
Email field set in dex config
Static user secrets created in Dex's namespace
@k8s-ci-robot
Copy link
Contributor

@krishnadurai: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-kfctl-presubmit 21c3b00 link /test kubeflow-kfctl-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aws-kf-ci-bot
Copy link

@krishnadurai: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-kfctl-presubmit 21c3b00 link /test kubeflow-kfctl-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PatrickXYS
Copy link
Member

/cc @krishnadurai

I assume this PR is not updated anymore, should we close it instead?

@google-oss-robot
Copy link

@PatrickXYS: GitHub didn't allow me to request PR reviews from the following users: krishnadurai.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @krishnadurai

I assume this PR is not updated anymore, should we close it instead?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants