end-to-end integration tests

[kunal-511]

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

This PR ensures Katib and KServe are properly installed in the GitHub Actions workflow before testing. It adds dedicated installation steps, removes conditional installs.

🐛 Related Issues

Fix #3054

✅ Contributor Checklist

• I have tested these changes with kustomize. See Installation Prerequisites.
• All commits are signed-off to satisfy the DCO check.

---

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

[kunal-511]

@juliusvonkohout
Is there a typo error in the spark_install.sh file because there is no directory with spark-operator/overlays/standalone instead it should be apps/spark-operator/overlays/standalone ?

[juliusvonkohout]

In general please.make sure that is is elegant and in line with the individual tests. They should have the same naming and structure. You can also alter the individual tests to achieve consistency. Before duplicating to much you should rather create a script under /tests/gh-actions and use it for the individual gha rest and this large end-to-end test here. We must avoid code duplication and encofce reusability.

[juliusvonkohout]

This gha is meant to be an orchestrator of the same scripts that are used for the individual gha workflows. It must be synchronized and rely on reusable scripts shared across multiple workflows.

[juliusvonkohout]

And you need to install spark as well. Please rely on the scripts and make the gha workflows consistent.

[kunal-511]

In general please.make sure that is is elegant and in line with the individual tests. They should have the same naming and structure. You can also alter the individual tests to achieve consistency. Before duplicating to much you should rather create a script under /tests/gh-actions and use it for the individual gha rest and this large end-to-end test here. We must avoid code duplication and encofce reusability.

I am thinking to make 4 separate files for install components, test utils, run test, verify components under the test/gh-actions. Is this the correct way to address the problem ??

[juliusvonkohout]

In general please.make sure that is is elegant and in line with the individual tests. They should have the same naming and structure. You can also alter the individual tests to achieve consistency. Before duplicating to much you should rather create a script under /tests/gh-actions and use it for the individual gha rest and this large end-to-end test here. We must avoid code duplication and encofce reusability.

I am thinking to make 4 separate files for install components, test utils, run test, verify components under the test/gh-actions. Is this the correct way to address the problem ??

For now please use the existing files. Modify the existing scripts as needed.

[juliusvonkohout]

I think these 2 lines belong to - name: Install Katib

[juliusvonkohout]

1. tests/gh-actions/install_central_dashboard.sh newest set -euxo pipefail
2. Please also apply the same changes to install_knative-cni.sh
   Both can be done in a follow up PR
3. Katib installation https://github.com/kubeflow/manifests/pull/3077/files/9d000044a0cfdc204b07ec0c4cc58c0dc95e422d#diff-4b30362af611e6ae2066d386c023437935b203936c034dd13c0fa669056c5175 and it should be in its own reusable script
   /lgtm
   /approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment