Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): Fix create_custom_training_job_from_component default location #11334

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

copybara-service[bot]
Copy link
Contributor

fix(components): Fix create_custom_training_job_from_component default location

Signed-off-by: Chen Sun [email protected]

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neuromage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @copybara-service[bot]. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 28, 2024
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 28, 2024
@copybara-service copybara-service bot force-pushed the test_690753890 branch 3 times, most recently from 2752cf8 to eca55f0 Compare October 29, 2024 01:22
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 29, 2024
@github-actions github-actions bot removed the ci-passed All CI tests on a pull request have passed label Oct 29, 2024
…t location

Signed-off-by: Chen Sun <[email protected]>
PiperOrigin-RevId: 691105600
@copybara-service copybara-service bot merged commit 04d600b into master Oct 29, 2024
@copybara-service copybara-service bot deleted the test_690753890 branch October 29, 2024 18:52
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed All CI tests on a pull request have passed needs-ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant