Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Add architecture diagram #11490

Merged
merged 3 commits into from
Jan 17, 2025
Merged

feat(docs): Add architecture diagram #11490

merged 3 commits into from
Jan 17, 2025

Conversation

anishasthana
Copy link
Contributor

Closes #10957

This is a first draft of an architecture diagram for Kubeflow Pipelines. I started with mermaid-js but it was taking a long while... I figured we can get something via draw.io diagram and then iterate over time.

cc @HumairAK

@anishasthana anishasthana changed the title feat(documentation): Add architecture diagram feat(docs): Add architecture diagram Dec 29, 2024
hbelmiro
hbelmiro reviewed Dec 30, 2024
View reviewed changes
images/kfp-cluster-wide-architecture.png Outdated Show resolved Hide resolved
images/kfp-cluster-wide-architecture.png Outdated Show resolved Hide resolved
images/kfp-cluster-wide-architecture.png Outdated Show resolved Hide resolved
@anishasthana anishasthana force-pushed the add_architecture_diagram branch from c93651e to 45cf652 Compare December 30, 2024 16:28
@anishasthana
Copy link
Contributor Author

@hbelmiro thanks for the review. I've made some updates.

hbelmiro
hbelmiro reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 30, 2024
rimolive
rimolive suggested changes Jan 2, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@anishasthana anishasthana force-pushed the add_architecture_diagram branch from 45cf652 to bcb8849 Compare January 2, 2025 17:38
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 2, 2025
@rimolive
Copy link
Member

rimolive commented Jan 9, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 9, 2025
Achuth17
Achuth17 reviewed Jan 9, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@anishasthana anishasthana force-pushed the add_architecture_diagram branch from bcb8849 to 7770ba4 Compare January 10, 2025 18:09
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 10, 2025
@anishasthana anishasthana requested a review from rimolive January 10, 2025 18:12
@franciscojavierarceo
Copy link

image

@rimolive
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 10, 2025
@anishasthana anishasthana force-pushed the add_architecture_diagram branch from 7770ba4 to 02c16bd Compare January 10, 2025 18:42
HumairAK
HumairAK reviewed Jan 10, 2025
View reviewed changes
README.md Show resolved Hide resolved
@anishasthana anishasthana force-pushed the add_architecture_diagram branch from 02c16bd to 4df0788 Compare January 16, 2025 15:41
@HumairAK
Copy link
Collaborator

HumairAK commented Jan 16, 2025 •
edited
Loading

/lgtm
/approve

Thank you!

@anishasthana
Copy link
Contributor Author

/retest

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 16, 2025
@VaniHaripriya
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 16, 2025
hbelmiro
hbelmiro reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

/rerun-all

@anishasthana anishasthana reopened this Jan 16, 2025
@VaniHaripriya
Copy link
Contributor

/rerun-all

@hbelmiro
Copy link
Contributor

/close

@google-oss-prow Google OSS Prow
Copy link

@hbelmiro: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Jan 16, 2025
@hbelmiro
Copy link
Contributor

/reopen

@google-oss-prow google-oss-prow bot reopened this Jan 16, 2025
@google-oss-prow Google OSS Prow
Copy link

@hbelmiro: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

@anishasthana can you please rebase?

@anishasthana
Fix minor lint errors
b82dd8e 
Signed-off-by: Anish Asthana <[email protected]>
@anishasthana
Add Kubeflow Pipelines Architecture
784fa70 
Signed-off-by: Anish Asthana <[email protected]>
@anishasthana
Update community section
f98f79d 
Signed-off-by: Anish Asthana <[email protected]>
@anishasthana anishasthana force-pushed the add_architecture_diagram branch from 91dec3d to f98f79d Compare January 17, 2025 05:33
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 17, 2025
hbelmiro
hbelmiro approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 17, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, HumairAK, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3e423d8 into kubeflow:master Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK HumairAK left review comments

@Achuth17 Achuth17 Achuth17 left review comments

@hbelmiro hbelmiro hbelmiro approved these changes

@rimolive rimolive rimolive approved these changes

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@rimolive rimolive

@HumairAK HumairAK

@hbelmiro hbelmiro

@VaniHaripriya VaniHaripriya

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add clear architectural diagrams on how KFP works and fill out the operator guides
7 participants
@anishasthana @rimolive @franciscojavierarceo @HumairAK @VaniHaripriya @hbelmiro @Achuth17