chore: switch release/api generator images to ghcr #11528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
connor-mccarthy,
gkcalat,
gregsheremeta and
hbelmiro
HumairAK
force-pushed
the
update_api_rel_imgs
branch
from
dd567dc to
d06ca59
Compare
Also update the go version in api generator image to 1.23 The previous version used 1.20.5, in this version the go generate command would fail on the current go mod (using 1.22), because it expects the go version to be in the format "x.y" insted of "x.y.z", in 1.23 this is no longer an issue. Signed-off-by: Humair Khan <[email protected]>
HumairAK
force-pushed
the
update_api_rel_imgs
branch
from
d06ca59 to
6b25a18
Compare
|
cc @chensun |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
By passing CI Check (it's broken right now, fix pending) |
HumairAK
added a commit
to HumairAK/data-science-pipelines
that referenced
this pull request
Jan 16, 2025
Also update the go version in api generator image to 1.23 The previous version used 1.20.5, in this version the go generate command would fail on the current go mod (using 1.22), because it expects the go version to be in the format "x.y" insted of "x.y.z", in 1.23 this is no longer an issue. Signed-off-by: Humair Khan <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Also update the go version in api generator image to 1.23 The previous version used 1.20.5, in this version the go generate command would fail on the current go mod (using 1.22), because it expects the go version to be in the format "x.y" insted of "x.y.z", in 1.23 this is no longer an issue. Signed-off-by: Humair Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Also update the go version in api generator image to 1.23 The previous version used 1.20.5, in this version the go generate command would fail on the current go mod (using 1.22), because it expects the go version to be in the format "x.y" insted of "x.y.z", in 1.23 this is no longer an issue. In our project go mod we use
1.22.0The packages are built (docs on how to push them were updated) and can be find here:
https://github.com/kubeflow/pipelines/pkgs/container/kfp-release
https://github.com/kubeflow/pipelines/pkgs/container/kfp-api-generator
I switched from SHA's to version tags. While sha's are more explicit/immutable, because the release/api-generator images are so tightly coupled, it made sense to me to version them and keep them aligned. It's also just easier to follow/read.
If there are strong opinions around using sha's, we can always switch back.
Checklist: