-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): bumped version to 2.4.0 #11531
Conversation
Signed-off-by: Humair Khan <[email protected]>
1b43bdb
to
1b2c63f
Compare
@HumairAK there seems to be some unrelated code changes in this PR. Was that intentional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HumairAK why do we need those .gitlab-ci-yml
and .travis.yml
?
these are auto generated files folks, I'll send another commit to remove it, but we'll need to update the automation to prevent the generation of these |
these files are created via the release.sh and don't seem like they are needed any more, a follow up change to fix the automation here will also be needed Signed-off-by: Humair Khan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
backend/api/v2beta1/python_http_client/kfp_server_api/models/v2beta1_experiment.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: hbelmiro, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Bump master to 2.4.0
Note that the release.sh script adds some travis/gitlab ci files that I have ommitted as a new commit. Also note that the python client regeneration produced some diffs due to this field that was added. This should have been included as part of this commit but was missed (note: ci needed here).
Checklist: