Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation for contribution and developer guide #11537

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

assu-2000
Copy link
Contributor

What this PR does:

This pull request fixes a minor typo in the Kubeflow Pipelines documentation. Specifically:

  • The word "reagd" was corrected to "read" in the sentence: "To learn how to build and deploy Kubeflow Pipelines from source code, read the developer guide".

Why this is important:

Ensuring the documentation is clear and free from errors is essential for improving the developer experience, especially for new contributors.

Checklist:

  • Corrected typo in the developer guide reference.
  • Verified that links in the sentence point to the correct resources.

Thank you for reviewing this PR!

Copy link

Hi @assu-2000. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@assu-2000
Copy link
Contributor Author

@assu-2000 please sign off your commits.

Done !

@hbelmiro
Copy link
Contributor

@assu-2000 please sign off your commits.

Done !

Not yet.

Screenshot 2025-01-20 at 12 35 27

@assu-2000
Copy link
Contributor Author

@assu-2000 please sign off your commits.

Done !

Not yet.

Screenshot 2025-01-20 at 12 35 27

Ooops, just fixed it ✅ !

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

cc @HumairAK

@HumairAK
Copy link
Collaborator

/approve

Thanks!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1234c8d into kubeflow:master Jan 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants