-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for cert-manager certificates to manage webhook TLS. #1567
Conversation
@dskatz This change would be helpful to the stability of the operator, the operator breaks from time to time after the cleanup job. any reason for not merging? |
We need this, any update on merging this? |
@dskatz Could you resolve the merge conflicts? |
I opened my own fork and cloned this PR trying to resolve the merge conflicts: #2079 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Was this effectively handled as part of the big rewrite? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
This PR can resolve: #1178
This adds the option for the mutation webhook TLS Certificate management to be done by cert-manager.
webhook-init-job
andwebhook-cleanup-job
are disabled, since it will be unnecessary to generate certificates adhoc.Open to suggestions on adjustment of the
values
interface and configuration.