Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend/Resume feature on SparkApplication #2387

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

everpeace
Copy link

@everpeace everpeace commented Jan 17, 2025

Purpose of this PR

This PR implements Suspend/Resume operation on SparkApplication.

Proposed changes:

  • Add Suspend: true|false field in SparkApplicationSpec
  • State Transition:
    • Suspend: ** --Suspend: true--> SUSPENDING --> SUSPENDED (**=any non-Terminal Application State)
    • Resume: SUSPENDING | SUSPENDED --Suspend: false--> RESUMING --> SUBMITTED

Fixes #2290

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Supporting Suspend/Resume feature could make Kueue integration easier.

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Shingo Omura <[email protected]>
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vara-bonthu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…cationStates(Suspending/Suspended/Resuming)

Signed-off-by: Shingo Omura <[email protected]>
Signed-off-by: Shingo Omura <[email protected]>
Signed-off-by: Shingo Omura <[email protected]>
@everpeace everpeace marked this pull request as ready for review January 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for suspend
1 participant