Use multiple ACM repos and create a code-intelligence cluster.#670
Merged
k8s-ci-robot merged 1 commit intokubeflow:masterfrom May 26, 2020
Merged
Use multiple ACM repos and create a code-intelligence cluster.#670k8s-ci-robot merged 1 commit intokubeflow:masterfrom
k8s-ci-robot merged 1 commit intokubeflow:masterfrom
Conversation
* For now, it looks like using multiple acm-repo (i.e. different
repos for different clusters) will work better than trying
to use a single acm-repo and cluster selectors.
* I was hitting problems with the fact that Tekton can't be installed
via ACM right now (it violates certain validation constraints).
* I only wanted to install tekton on the auto-deploy cluster (kf-ci-v1)
and not the kf-ci-management cluster but I was stil
getting errors from ACM complaining the Tekton configs were invalid.
* So as a work around I renamed acm-repo -> acm-repos with the intent
we will have multiple subdirectories corresponding to different repos
* A given cluster can then choose which cluster to enroll in
* Create a new cluster for the KF chatbot (see kubeflow/code-intelligence#142)
* The cluster will be managed using CNRM and ACM on the kf-ci-management
cluster. So we need to check in the configs.
* The source (kustomize packages for the manifests) is in
kubeflow/code-intelligence#145
|
This change is |
Contributor
Author
|
/assign @Bobgy |
Contributor
|
/lgtm |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, it looks like using multiple acm-repo (i.e. different
repos for different clusters) will work better than trying
to use a single acm-repo and cluster selectors.
I was hitting problems with the fact that Tekton can't be installed
via ACM right now (it violates certain validation constraints).
I only wanted to install tekton on the auto-deploy cluster (kf-ci-v1)
and not the kf-ci-management cluster but I was stil
getting errors from ACM complaining the Tekton configs were invalid.
So as a work around I renamed acm-repo -> acm-repos with the intent
we will have multiple subdirectories corresponding to different repos
A given cluster can then choose which cluster to enroll in
Create a new cluster for the KF chatbot (see [chatbot] Start building a KF assistant - who owns this label? code-intelligence#142)
The cluster will be managed using CNRM and ACM on the kf-ci-management
cluster. So we need to check in the configs.
The source (kustomize packages for the manifests) is in
Create a new cluster for chatbot based on the GCP blueprint. code-intelligence#145