Skip to content

Commit

Permalink
Fixing build broken links for netlify build (remove from todoPatterns) (
Browse files Browse the repository at this point in the history
#3963)

* test: netlify deploy test

Signed-off-by: Akash Jaiswal <[email protected]>

* revert: some of the todoPatters which were failing

Signed-off-by: Akash Jaiswal <[email protected]>

* fix: 3 build todo patterns

Signed-off-by: Akash Jaiswal <[email protected]>

* fix: gke issue

Signed-off-by: Akash Jaiswal <[email protected]>

* move: shared-resoures to skipPatterns

Signed-off-by: Akash Jaiswal <[email protected]>

---------

Signed-off-by: Akash Jaiswal <[email protected]>
  • Loading branch information
jaiakash authored Jan 29, 2025
1 parent 2a5ef22 commit 06b1b77
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Kubeflow Pipelines is configured with the authentication of the MinIO instance d
#### GCS
If you want to specify the `pipeline root` to GCS :

check [authentication-pipelines](https://www.kubeflow.org/docs/distributions/gke/pipelines/authentication-pipelines/)
check [authentication-pipelines](https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/pipelines/authentication-pipelines/)

#### S3
If you want to specify the `pipeline root` to S3, please choose one of the following options:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,10 @@ bases:
MountVolume.SetUp failed for volume "gcp-credentials-user-gcp-sa" : secret "user-gcp-sa" not found
```
You should remove `use_gcp_secret` usages as documented in [Authenticating Pipelines to GCP](/docs/distributions/gke/pipelines/authentication-pipelines/#authoring-pipelines-to-use-workload-identity).
You should remove `use_gcp_secret` usages as documented in [Authenticating Pipelines to GCP](https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/pipelines/authentication-pipelines/#authoring-pipelines-to-use-workload-identity).
## What's next
* [Connecting to Kubeflow Pipelines standalone on Google Cloud using the SDK](/docs/distributions/gke/pipelines/authentication-sdk/#connecting-to-kubeflow-pipelines-standalone-or-ai-platform-pipelines)
* [Authenticating Pipelines to GCP](/docs/distributions/gke/pipelines/authentication-pipelines/#authoring-pipelines-to-use-workload-identity) if you want to use GCP services in Kubeflow Pipelines.
* [Connecting to Kubeflow Pipelines standalone on Google Cloud using the SDK](https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/pipelines/authentication-sdk/#connecting-to-kubeflow-pipelines-standalone-or-ai-platform-pipelines)
* [Authenticating Pipelines to GCP](https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/pipelines/authentication-pipelines/#authoring-pipelines-to-use-workload-identity) if you want to use GCP services in Kubeflow Pipelines.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This page introduces notices and breaking changes you need to know when upgradin

For upgrade instructions, refer to distribution specific documentations:

* [Upgrading Kubeflow Pipelines on Google Cloud](/docs/distributions/gke/pipelines/upgrade/)
* [Upgrading Kubeflow Pipelines on Google Cloud](https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/pipelines/upgrade/)

## Upgrading to v2.0

Expand Down
2 changes: 1 addition & 1 deletion content/en/docs/components/training/user-guides/mpi.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cd mpi-operator
kubectl apply -f deploy/v2beta1/mpi-operator.yaml
```

Alternatively, follow the [getting started guide](https://www.kubeflow.org/docs/started/getting-started/) to deploy Kubeflow.
Alternatively, follow the [getting started guide](https://www.kubeflow.org/docs/started/installing-kubeflow/) to deploy Kubeflow.

An alpha version of MPI support was introduced with Kubeflow 0.2.0. You must be using a version of Kubeflow newer than 0.2.0.

Expand Down
3 changes: 1 addition & 2 deletions content/en/docs/started/support.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,8 @@ You can ask questions and make suggestions in the following places:
* **Kubeflow documentation** for overviews and how-to guides. In particular,
refer to the following documents when troubleshooting a problem:

* [Kubeflow installation and setup](/docs/started/getting-started/)
* [Kubeflow installation and setup](/docs/started/installing-kubeflow/)
* [Kubeflow components](/docs/components/)
* [Further setup and troubleshooting](/docs/other-guides/)

* **Kubeflow issue trackers** for known issues, questions, and feature requests.
Search the open issues to see if someone else has already logged the problem
Expand Down
23 changes: 0 additions & 23 deletions netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,30 +23,7 @@ package = "netlify-plugin-checklinks"
# ignore absolute links, which are only found in tags like `<meta property="og:url" content="URL_HERE">`
# https://github.com/Munter/netlify-plugin-checklinks/issues/388
"competent-brattain-de2d6d.netlify.app",
]

# If a link contains these patterns it will not fail the build, but will be reported as a TODO in the build log.
todoPatterns = [

# These are referenced by autogenerated files:
"public/docs/components/pipelines/legacy-v1/reference/api/fonts/",
"public/docs/components/pipelines/reference/api/fonts/",
"public/docs/components/pipelines/fonts/",
"public/docs/components/pipelines/legacy-v1/fonts/",

"public/docs/distributions/gke/",

"public/docs/distributions/aws/",
"public/docs/distributions/ibm/",

"public/fonts/glyphicons",
"public/docs/experiment",
"public/docs/suggestion",
"public/docs/trial",
"public/docs/examples/shared-resources",
"public/docs/started/getting-started",
"public/docs/other-guides",
"public/docs/external-add-ons/istio",
]

[context.deploy-preview.environment]
Expand Down

0 comments on commit 06b1b77

Please sign in to comment.