-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong targetPort type preventing service api calls #425
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhkimac The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jhkimac! |
/assign @mbohlool |
Hi, @jhkimac Thanks so much for this contribution! Sadly we can't accept this as is, as this code is automatically generated from the openApi spec. So we need to fix it upstream in the generator or in the openApi spec. See https://github.com/kubernetes-client/javascript#re-generating-code which calls https://github.com/kubernetes-client/javascript/blob/master/generate-client.sh How does this fix it compared to the /assign @drubin |
Hi @drubin, I will try it out after a take a bit of rest. In the meantime, I have also found similar behavior in V1Container's |
This is discussed in #349 there's something weird going on with the Swagger and the code generator. It has to do with the way that IntOrString is represented in Swagger, and also what looks like it might be a bug in the code generator. I've take a few attempts at fixing this, but it hasn't gone anywhere. As @drubin says, we can't manually edit the code generated files. |
Closing this PR since we can't merge it. Please continue discussion as needed in #349 |
No description provided.