Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated code migration from request to node-fetch/isomorphic-fetch #773

Closed

Conversation

davidgamero
Copy link
Contributor

migration of OpenAPIGenerator code to current typescript generator that no longer uses request
in reference to #754

Note: this will leave the master branch in a development state as the migration doesn't cover the /src/*.ts files that still use request.
Merging this would allow the work of updating all the non-generated code to be parallelized on master.

Notable remaining migration work:
-watch.ts, log.ts, and metrics.ts all directly implement request without using the generated apiclient
-config.ts needs to be refactored from the applyToRequest() method to the new applySecurityAuthentication() method now that the generated code uses a SecurityAuthentication interface for creating a RequestContext instead of directly passing https.Options

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 3, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @davidgamero!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidgamero
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 3, 2022
@brendandburns
Copy link
Contributor

Thanks!

Can you split this PR into two commits: 1) generated code changes. 2) any hand-edited changes.

It's basically impossible to review the generated code because there are so many files, but I would like to review any hand-edited changes.

Also you need to sign the CLA. Just do the EasyCLA one b/c there is migration happening to that today-ish.

@davidgamero
Copy link
Contributor Author

The only hand-edited change in this PR is the GEN_COMMIT hash, and I will be making a separate PR for the hand-edited changes after this one for converting the config to the new interfaces.
Should I do the GEN_COMMIT hash change in a separate commit from the code generated by altering it for clarity?

Sounds good I'll do the CLA

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

@davidgamero: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

@davidgamero I created a release-1.x repo. Let's move this PR to target that repo and we can merge and iterate.

@davidgamero davidgamero changed the base branch from master to release-1.x February 9, 2022 23:52
@davidgamero
Copy link
Contributor Author

perfect. just retargeted the PR

@davidgamero
Copy link
Contributor Author

looks like the PR might need a rebase- I could just open a new one at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants