Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert log to use fetch streaming #822

Merged
merged 3 commits into from
Jun 18, 2022
Merged

convert log to use fetch streaming #822

merged 3 commits into from
Jun 18, 2022

Conversation

davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Jun 17, 2022 •
edited
Loading

remove another remaining usage of the request library
ref #754

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022
brendandburns
brendandburns reviewed Jun 17, 2022
View reviewed changes
src/log.ts Outdated Show resolved Hide resolved
brendandburns
brendandburns reviewed Jun 17, 2022
View reviewed changes
src/log.ts Outdated Show resolved Hide resolved
@brendandburns
Copy link
Contributor

Couple of comments, is there a unit test that needs updating also?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2022
@davidgamero
Copy link
Contributor Author

Couple of comments, is there a unit test that needs updating also?

i don't believe there was a log_test, but i added one for param parsing

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 99368ce into kubernetes-client:release-1.x Jun 18, 2022
@davidgamero davidgamero mentioned this pull request Oct 31, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgamero @brendandburns @k8s-ci-robot