Skip to content

Commit

Permalink
Merge pull request #844 from mowangdk/cleanup/adopt_kubernetes_recomm…
Browse files Browse the repository at this point in the history
…and_labels

chore: Adopt kubernetes recommand label
  • Loading branch information
k8s-ci-robot authored Sep 20, 2023
2 parents 215f12f + f83e81a commit 6c07fa0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions deploy/kubernetes/csi-snapshotter/setup-csi-snapshotter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ apiVersion: v1
metadata:
name: csi-snapshotter
labels:
app: csi-snapshotter
app.kubernetes.io/name: csi-snapshotter
spec:
selector:
app: csi-snapshotter
app.kubernetes.io/name: csi-snapshotter
ports:
- name: dummy
port: 12345
Expand All @@ -63,11 +63,11 @@ spec:
replicas: 1
selector:
matchLabels:
app: csi-snapshotter
app.kubernetes.io/name: csi-snapshotter
template:
metadata:
labels:
app: csi-snapshotter
app.kubernetes.io/name: csi-snapshotter
spec:
serviceAccountName: csi-snapshotter
containers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
replicas: 2
selector:
matchLabels:
app: snapshot-controller
app.kubernetes.io/name: snapshot-controller
# the snapshot controller won't be marked as ready if the v1 CRDs are unavailable
# in #504 the snapshot-controller will exit after around 7.5 seconds if it
# can't find the v1 CRDs so this value should be greater than that
Expand All @@ -28,7 +28,7 @@ spec:
template:
metadata:
labels:
app: snapshot-controller
app.kubernetes.io/name: snapshot-controller
spec:
serviceAccountName: snapshot-controller
containers:
Expand Down
8 changes: 4 additions & 4 deletions deploy/kubernetes/webhook-example/webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ metadata:
name: snapshot-validation-deployment
namespace: default # NOTE: change the namespace
labels:
app: snapshot-validation
app.kubernetes.io/name: snapshot-validation
spec:
replicas: 3
selector:
matchLabels:
app: snapshot-validation
app.kubernetes.io/name: snapshot-validation
template:
metadata:
labels:
app: snapshot-validation
app.kubernetes.io/name: snapshot-validation
spec:
serviceAccountName: snapshot-webhook
containers:
Expand All @@ -40,7 +40,7 @@ metadata:
namespace: default # NOTE: change the namespace
spec:
selector:
app: snapshot-validation
app.kubernetes.io/name: snapshot-validation
ports:
- protocol: TCP
port: 443 # Change if needed
Expand Down

0 comments on commit 6c07fa0

Please sign in to comment.