Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Patch to add finalizers, Get updated objects when removing finalizer with update fails with conflict. #1023

Closed
wants to merge 10 commits into from
Closed

Use Patch to add finalizers, Get updated objects when removing finalizer with update fails with conflict. #1023

wants to merge 10 commits into from

Commits on Feb 24, 2024

  1. Use patch instead of update for GroupSnapshots and VolumeSnapshots 

    Signed-off-by: Tiger Kaovilai <[email protected]>

remove debugging code

Signed-off-by: Tiger Kaovilai <[email protected]>

remove more update calls

Signed-off-by: Tiger Kaovilai <[email protected]>

Fix patch json unmarshal unitTests comparison failures

Signed-off-by: Tiger Kaovilai <[email protected]>

Fix tests in reactor by not modifying original for patch

Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    3baa459 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Use remove all + add instead of removing by index 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2e56da8 View commit details
    Browse the repository at this point in the history

  2. fix sync tests 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6740b07 View commit details
    Browse the repository at this point in the history

  3. clean up debugging content 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    84e574f View commit details
    Browse the repository at this point in the history

  4. go fmt 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    db6559f View commit details
    Browse the repository at this point in the history

  5. Use update to remove finalizers instead of patch with get retries 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    931529b View commit details
    Browse the repository at this point in the history

  6. Use generics for Update function 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9d6b138 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Remove recursion, add conflict tests 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    03a1484 View commit details
    Browse the repository at this point in the history

  2. go fmt 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4541deb View commit details
    Browse the repository at this point in the history

  3. add wait backoff 

    Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    kaovilai committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8c61946 View commit details
    Browse the repository at this point in the history