-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow csi-snapshotter to create and manage VolumeSnapshots #959
Allow csi-snapshotter to create and manage VolumeSnapshots #959
Conversation
|
Welcome @leonardoce! |
Hi @leonardoce. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/release-note-none |
/ok-to-test |
This PR is merged and fixed the Trivy issue: #962. Can you rebase? |
This patch allows the `external-snapshotter-runner` ClusterRole, which is bound to the `csi-snapshotter` Service Account, to create and manage VolumeSnapshot objects. This is needed during the synchronization of VolumeGroupSnapshots.
232475f
to
6ac1229
Compare
Done @xing-yang. Thank you! |
/lgtm Thanks @leonardoce ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch allows the
external-snapshotter-runner
ClusterRole, bound to thecsi-snapshotter
Service Account, to create and manage VolumeSnapshot objects.This is needed during the synchronization of VolumeGroupSnapshots.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We need this permission to reconcile VolumeGroupSnapshot objects, which in turn will create VolumeSnapshot and VolumeSnapshotContent resources.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE