-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow snapshot controller to delete VolumeSnapshots #961
Allow snapshot controller to delete VolumeSnapshots #961
Conversation
Hi @leonardoce. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This PR is merged and fixed the Trivy issue: #962. Can you rebase? |
This patch allows the snapshot-controller-runner ClusterRole, bound to the snapshot-controller Service Account, to delete VolumeSnapshot objects. This is needed during the VolumeGroupSnapshot deletion. Signed-off-by: Leonardo Cecchi <[email protected]>
9c60660
to
17f739c
Compare
I rebased it @xing-yang. Thank you! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch allows the snapshot-controller-runner ClusterRole, bound to the snapshot-controller Service Account, to delete VolumeSnapshot objects. This is needed during the VolumeGroupSnapshot deletion.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: