Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

🐛 Adding back original all_in_one.yaml for VC #144

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

christopherhein
Copy link
Contributor

What this PR does / why we need it:
I accidentally renamed instead of copying the manifest which broke the demo docs. This reverts those changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Reverts #142
Reverts #136

Specifically that the all_in_one.yaml was just supposed to be copied while we transition from vc-manager provisioned to capi provisioned.

Signed-off-by: Chris Hein [email protected]

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2021
@christopherhein
Copy link
Contributor Author

/assign @Fei-Guo

/cc @vincent-pli

@k8s-ci-robot
Copy link
Contributor

@christopherhein: GitHub didn't allow me to request PR reviews from the following users: vincent-pli.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @Fei-Guo

/cc @vincent-pli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fei-Guo
Copy link

Fei-Guo commented Jun 21, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 98db462 into kubernetes-retired:main Jun 21, 2021
@christopherhein christopherhein deleted the all-in-one branch June 21, 2021 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants