Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Verification and Permission Issues in Static Bucket Creation and Deletion #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seven17777777
Copy link

The creation of a static bucket requires verification of whether there is a corresponding bucket on the storage, otherwise binding should failbucket on the storage, otherwise binding should fail

In a static bucket, where the bucket deletion policy is set to 'delete', if the ID specified in the cluster does not belong to the current user, deleting the bucket claim will attempt to delete the corresponding bucket. Due to the lack of verification, this may result in a situation where the bucket cannot be deleted because the user does not have the necessary permissions.

…e is a corresponding bucket on the storage, otherwise binding should fail
Copy link

linux-foundation-easycla bot commented Sep 1, 2024

CLA Not Signed

  • ❌ login: @yuyang520 / The commit (00f904a). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seven17777777
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @seven17777777!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-provisioner-sidecar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-provisioner-sidecar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @seven17777777. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants