[PoC] Enable Golang dead code elimination #1260
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Some packages use reflection in a way that prevents Golang linker from eliminating dead code in the binary. We should fix all of them.
This PR fixes them by switching to fork version, or modifying the vendor directory directly, just as a PoC. With all of them fixed, the binary size of CSI is shaken from 66M to 31M (47%), impressive!
Binary size tested by
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Depends on:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: