Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Enable Golang dead code elimination #1260

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Dec 7, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Some packages use reflection in a way that prevents Golang linker from eliminating dead code in the binary. We should fix all of them.

  • golang.org/x/net/trace renders go template in init()
  • github.com/json-iterator/go relies on github.com/modern-go/reflect2. This is used by
    • github.com/alibabacloud-go/tea/tea (aka. Alibaba Cloud OpenAPI SDK v2)
    • github.com/aliyun/alibaba-cloud-sdk-go/sdk (aka. Alibaba Cloud OpenAPI SDK v1)
    • sigs.k8s.io/structured-merge-diff/v4

This PR fixes them by switching to fork version, or modifying the vendor directory directly, just as a PoC. With all of them fixed, the binary size of CSI is shaken from 66M to 31M (47%), impressive!

Binary size tested by

GOOS=linux GOARCH=amd64 go build -ldflags '-s -w' .
du -h ./alibaba-cloud-csi-driver

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Depends on:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants