make lease label and lease namespace configurable #670
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| @@ -321,6 +330,13 @@ func (o *ProxyRunOptions) Validate() error { | |||
| } | |||
| } | |||
| } | |||
| // Validate labels provided. | |||
| if o.EnableLeaseController { | |||
| _, err := util.ParseLabels(o.LeaseLabel) | |||
There was a problem hiding this comment.
rather than parsing the labels more than once, would it make sense to store the result of the parsed label at this point?
There was a problem hiding this comment.
Didn't want to pollute the ProxyRunOptions struct with another label field, especially we are using once in validate and once to setup the server.
|
Nice change. I would like to see the Split vs SplitN change. The rest we can treat as feature requests. |
Signed-off-by: Imran Pochi <[email protected]>
ipochi
force-pushed
the
imran/make-lease-controller-configurable
branch
from
391b98a to
ea0a0d3
Compare
|
/approve |
|
@cheftako I believe this is good to get merged. |
ipochi
changed the title
| }, | ||
| shouldError: false, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Would be nice to have a test case like "foo=var=baz"
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, ipochi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently the lease controller system has hard coded values for lease namespace and lease labels.
This PR adds cli flags to make those values configurable.