Add Pod Disruption Budget and configurable deployment name #1404

omerap12 · 2024-07-07T07:16:35Z

Is this a bug fix or adding new feature?
Re-raising this PR #901. set configurable deployment and pdb name.
What is this PR about? / Why do we need it?
Fixes #1397
What testing is done?
Helm testing: the following values file:

nameOverride: ""
fullnameOverride: ""

replicaCount: 2

useFIPS: false

image:
  repository: public.ecr.aws/efs-csi-driver/amazon/aws-efs-csi-driver
  tag: "v2.0.5"
  pullPolicy: IfNotPresent

sidecars:
  livenessProbe:
    image:
      repository: public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe
      tag: v2.13.0-eks-1-30-8
      pullPolicy: IfNotPresent
    resources: {}
    securityContext:
      readOnlyRootFilesystem: true
      allowPrivilegeEscalation: false
  nodeDriverRegistrar:
    image:
      repository: public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar
      tag: v2.11.0-eks-1-30-8
      pullPolicy: IfNotPresent
    resources: {}
    securityContext:
      readOnlyRootFilesystem: true
      allowPrivilegeEscalation: false
  csiProvisioner:
    image:
      repository: public.ecr.aws/eks-distro/kubernetes-csi/external-provisioner
      tag: v5.0.1-eks-1-30-8
      pullPolicy: IfNotPresent
    resources: {}
    securityContext:
      readOnlyRootFilesystem: true
      allowPrivilegeEscalation: false

imagePullSecrets: []

## Controller deployment variables

controller:
  # Specifies whether a deployment should be created
  create: true
  # name of the controller deployment
  name: efs-csi-controller
  # Number for the log level verbosity
  logLevel: 2
  # If set, add pv/pvc metadata to plugin create requests as parameters.
  extraCreateMetadata: true
  # Add additional tags to access points
  tags:
    {}
    # environment: prod
    # region: us-east-1
  # Enable if you want the controller to also delete the
  # path on efs when deleteing an access point
  deleteAccessPointRootDir: false
  podAnnotations: {}
  podLabel: {}
  hostNetwork: false
  priorityClassName: system-cluster-critical
  dnsPolicy: ClusterFirst
  dnsConfig: {}
  additionalLabels: {}
  resources:
    {}
    # We usually recommend not to specify default resources and to leave this as a conscious
    # choice for the user. This also increases chances charts run on environments with little
    # resources, such as Minikube. If you do want to specify resources, uncomment the following
    # lines, adjust them as necessary, and remove the curly braces after 'resources:'.
    # limits:
    #   cpu: 100m
    #   memory: 128Mi
    # requests:
    #   cpu: 100m
    #   memory: 128Mi
  nodeSelector: {}
  updateStrategy: {}
  tolerations:
    - key: CriticalAddonsOnly
      operator: Exists
    - key: efs.csi.aws.com/agent-not-ready
      operator: Exists
  affinity: {}
  env: []
  volumes: []
  volumeMounts: []
  # Specifies whether a service account should be created
  serviceAccount:
    create: true
    name: efs-csi-controller-sa
    annotations: {}
    ## Enable if EKS IAM for SA is used
    #  eks.amazonaws.com/role-arn: arn:aws:iam::111122223333:role/efs-csi-role
  healthPort: 9909
  regionalStsEndpoints: false
  # Pod Disruption Budget
  pdb:
    minAvailable: 1
  # securityContext on the controller pod
  securityContext:
    runAsNonRoot: false
    runAsUser: 0
    runAsGroup: 0
    fsGroup: 0
  # securityContext on the controller container
  # Setting privileged=false will cause the "delete-access-point-root-dir" controller option to fail
  containerSecurityContext:
    privileged: true
  leaderElectionRenewDeadline: 10s
  leaderElectionLeaseDuration: 15s


## Node daemonset variables

node:
  # Number for the log level verbosity
  logLevel: 2
  volMetricsOptIn: false
  volMetricsRefreshPeriod: 240
  volMetricsFsRateLimit: 5
  hostAliases:
    {}
    # For cross VPC EFS, you need to poison or overwrite the DNS for the efs volume as per
    # https://docs.aws.amazon.com/efs/latest/ug/efs-different-vpc.html#wt6-efs-utils-step3
    # implementing the suggested solution found here:
    # https://github.com/kubernetes-sigs/aws-efs-csi-driver/issues/240#issuecomment-676849346
    # EFS Vol ID, IP, Region
    # "fs-01234567":
    #   ip: 10.10.2.2
    #   region: us-east-2
  priorityClassName: system-node-critical
  dnsPolicy: ClusterFirst
  dnsConfig:
    {}
    # Example config which uses the AWS nameservers
    # dnsPolicy: "None"
    # dnsConfig:
    #   nameservers:
    #     - 169.254.169.253
  podLabels: {}
  podAnnotations: {}
  additionalLabels: {}
  resources:
    {}
    # limits:
    #   cpu: 100m
    #   memory: 128Mi
    # requests:
    #   cpu: 100m
    #   memory: 128Mi
  nodeSelector: {}
  updateStrategy: {}
    # Override default strategy (RollingUpdate) to speed up deployment.
    # This can be useful if helm timeouts are observed.
    # type: OnDelete
  tolerations:
    - operator: Exists
  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: eks.amazonaws.com/compute-type
                operator: NotIn
                values:
                  - fargate
  # Specifies whether a service account should be created
  serviceAccount:
    create: true
    name: efs-csi-node-sa
    annotations: {}
    ## Enable if EKS IAM for SA is used
    #  eks.amazonaws.com/role-arn: arn:aws:iam::111122223333:role/efs-csi-role
  healthPort: 9809
  # securityContext on the node pod
  securityContext:
    # The node pod must be run as root to bind to the registration/driver sockets
    runAsNonRoot: false
    runAsUser: 0
    runAsGroup: 0
    fsGroup: 0
  env: []
  volumes: []
  volumeMounts: []

storageClasses: []
# Add StorageClass resources like:
# - name: efs-sc
#   annotations:
#     # Use that annotation if you want this to your default storageclass
#     storageclass.kubernetes.io/is-default-class: "true"
#   mountOptions:
#   - tls
#   parameters:
#     provisioningMode: efs-ap
#     fileSystemId: fs-1122aabb
#     directoryPerms: "700"
#     gidRangeStart: "1000"
#     gidRangeEnd: "2000"
#     basePath: "/dynamic_provisioning"
#     subPathPattern: "/subPath"
#     ensureUniqueDirectory: true
#   reclaimPolicy: Delete
#   volumeBindingMode: Immediate

provides this output:

---
# Source: aws-efs-csi-driver/templates/controller-pdb.yaml
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
  name: efs-csi-controller
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
spec:
  selector:
    matchLabels:
      app: efs-csi-controller
      app.kubernetes.io/name: aws-efs-csi-driver
      app.kubernetes.io/instance: release-name
  minAvailable: 1
---
# Source: aws-efs-csi-driver/templates/controller-serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: efs-csi-controller-sa
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
---
# Source: aws-efs-csi-driver/templates/node-serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: efs-csi-node-sa
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
---
# Source: aws-efs-csi-driver/templates/controller-serviceaccount.yaml
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: efs-csi-external-provisioner-role
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
rules:
  - apiGroups: [""]
    resources: ["persistentvolumes"]
    verbs: ["get", "list", "watch", "create", "patch", "delete"]
  - apiGroups: [""]
    resources: ["persistentvolumeclaims"]
    verbs: ["get", "list", "watch", "update"]
  - apiGroups: ["storage.k8s.io"]
    resources: ["storageclasses"]
    verbs: ["get", "list", "watch"]
  - apiGroups: [""]
    resources: ["events"]
    verbs: ["list", "watch", "create", "patch"]
  - apiGroups: ["storage.k8s.io"]
    resources: ["csinodes"]
    verbs: ["get", "list", "watch"]
  - apiGroups: [""]
    resources: ["nodes"]
    verbs: ["get", "list", "watch"]
  - apiGroups: ["coordination.k8s.io"]
    resources: ["leases"]
    verbs: ["get", "watch", "list", "delete", "update", "create"]
---
# Source: aws-efs-csi-driver/templates/controller-serviceaccount.yaml
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: efs-csi-external-provisioner-role-describe-secrets
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
rules:
  - apiGroups: [ "" ]
    resources: [ "secrets" ]
    resourceNames: ["x-account"]
    verbs: [ "get", "watch", "list" ]
---
# Source: aws-efs-csi-driver/templates/node-serviceaccount.yaml
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: efs-csi-node-role
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
rules:
  - apiGroups: [""]
    resources: ["nodes"]
    verbs: ["get", "list", "watch", "patch"]
---
# Source: aws-efs-csi-driver/templates/controller-serviceaccount.yaml
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: efs-csi-provisioner-binding
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
subjects:
  - kind: ServiceAccount
    name: efs-csi-controller-sa
    namespace: default
roleRef:
  kind: ClusterRole
  name: efs-csi-external-provisioner-role
  apiGroup: rbac.authorization.k8s.io
---
# Source: aws-efs-csi-driver/templates/node-serviceaccount.yaml
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: efs-csi-node-binding
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
subjects:
  - kind: ServiceAccount
    name: efs-csi-node-sa
    namespace: default
roleRef:
  kind: ClusterRole
  name: efs-csi-node-role
  apiGroup: rbac.authorization.k8s.io
---
# Source: aws-efs-csi-driver/templates/controller-serviceaccount.yaml
# We use a RoleBinding to restrict Secret access to the namespace that the 
# RoleBinding is created in (typically kube-system)
kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: efs-csi-provisioner-binding-describe-secrets
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
subjects:
  - kind: ServiceAccount
    name: efs-csi-controller-sa
    namespace: default
roleRef:
  kind: ClusterRole
  name: efs-csi-external-provisioner-role-describe-secrets
  apiGroup: rbac.authorization.k8s.io
---
# Source: aws-efs-csi-driver/templates/node-daemonset.yaml
# Node Service
kind: DaemonSet
apiVersion: apps/v1
metadata:
  name: efs-csi-node
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
spec:
  selector:
    matchLabels:
      app: efs-csi-node
      app.kubernetes.io/name: aws-efs-csi-driver
      app.kubernetes.io/instance: release-name
  template:
    metadata:
      labels:
        app: efs-csi-node
        app.kubernetes.io/name: aws-efs-csi-driver
        app.kubernetes.io/instance: release-name
    spec:
      nodeSelector:
        kubernetes.io/os: linux
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: eks.amazonaws.com/compute-type
                operator: NotIn
                values:
                - fargate
      hostNetwork: true
      dnsPolicy: ClusterFirst
      serviceAccountName: efs-csi-node-sa
      priorityClassName: system-node-critical
      tolerations:
        - operator: Exists
      securityContext:
        fsGroup: 0
        runAsGroup: 0
        runAsNonRoot: false
        runAsUser: 0
      containers:
        - name: efs-plugin
          securityContext:
            privileged: true
          image: public.ecr.aws/efs-csi-driver/amazon/aws-efs-csi-driver:v2.0.5
          imagePullPolicy: IfNotPresent
          args:
            - --endpoint=$(CSI_ENDPOINT)
            - --logtostderr
            - --v=2
            - --vol-metrics-opt-in=false
            - --vol-metrics-refresh-period=240
            - --vol-metrics-fs-rate-limit=5
          env:
            - name: CSI_ENDPOINT
              value: unix:/csi/csi.sock
            - name: CSI_NODE_NAME
              valueFrom:
                fieldRef:
                  fieldPath: spec.nodeName
          volumeMounts:
            - name: kubelet-dir
              mountPath: /var/lib/kubelet
              mountPropagation: "Bidirectional"
            - name: plugin-dir
              mountPath: /csi
            - name: efs-state-dir
              mountPath: /var/run/efs
            - name: efs-utils-config
              mountPath: /var/amazon/efs
            - name: efs-utils-config-legacy
              mountPath: /etc/amazon/efs-legacy
          ports:
            - name: healthz
              containerPort: 9809
              protocol: TCP
          livenessProbe:
            httpGet:
              path: /healthz
              port: healthz
            initialDelaySeconds: 10
            timeoutSeconds: 3
            periodSeconds: 2
            failureThreshold: 5
        - name: csi-driver-registrar
          image: public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.11.0-eks-1-30-8
          imagePullPolicy: IfNotPresent
          args:
            - --csi-address=$(ADDRESS)
            - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
            - --v=2
          env:
            - name: ADDRESS
              value: /csi/csi.sock
            - name: DRIVER_REG_SOCK_PATH
              value: /var/lib/kubelet/plugins/efs.csi.aws.com/csi.sock
            - name: KUBE_NODE_NAME
              valueFrom:
                fieldRef:
                  fieldPath: spec.nodeName
          volumeMounts:
            - name: plugin-dir
              mountPath: /csi
            - name: registration-dir
              mountPath: /registration
          securityContext:
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: true
        - name: liveness-probe
          image: public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe:v2.13.0-eks-1-30-8
          imagePullPolicy: IfNotPresent
          args:
            - --csi-address=/csi/csi.sock
            - --health-port=9809
            - --v=2
          volumeMounts:
            - name: plugin-dir
              mountPath: /csi
          securityContext:
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: true
      volumes:
        - name: kubelet-dir
          hostPath:
            path: /var/lib/kubelet
            type: Directory
        - name: plugin-dir
          hostPath:
            path: /var/lib/kubelet/plugins/efs.csi.aws.com/
            type: DirectoryOrCreate
        - name: registration-dir
          hostPath:
            path: /var/lib/kubelet/plugins_registry/
            type: Directory
        - name: efs-state-dir
          hostPath:
            path: /var/run/efs
            type: DirectoryOrCreate
        - name: efs-utils-config
          hostPath:
            path: /var/amazon/efs
            type: DirectoryOrCreate
        - name: efs-utils-config-legacy
          hostPath:
            path: /etc/amazon/efs
            type: DirectoryOrCreate
---
# Source: aws-efs-csi-driver/templates/controller-deployment.yaml
# Controller Service
kind: Deployment
apiVersion: apps/v1
metadata:
  name: efs-csi-controller
  labels:
    app.kubernetes.io/name: aws-efs-csi-driver
spec:
  replicas: 2
  selector:
    matchLabels:
      app: efs-csi-controller
      app.kubernetes.io/name: aws-efs-csi-driver
      app.kubernetes.io/instance: release-name
  template:
    metadata:
      labels:
        app: efs-csi-controller
        app.kubernetes.io/name: aws-efs-csi-driver
        app.kubernetes.io/instance: release-name
    spec:
      hostNetwork: false
      nodeSelector:
        kubernetes.io/os: linux
      serviceAccountName: efs-csi-controller-sa
      priorityClassName: system-cluster-critical
      tolerations:
        - key: CriticalAddonsOnly
          operator: Exists
        - key: efs.csi.aws.com/agent-not-ready
          operator: Exists
      securityContext:
        fsGroup: 0
        runAsGroup: 0
        runAsNonRoot: false
        runAsUser: 0
      dnsPolicy: ClusterFirst
      containers:
        - name: efs-plugin
          securityContext:
            privileged: true
          image: public.ecr.aws/efs-csi-driver/amazon/aws-efs-csi-driver:v2.0.5
          imagePullPolicy: IfNotPresent
          args:
            - --endpoint=$(CSI_ENDPOINT)
            - --logtostderr
            - --v=2
            - --delete-access-point-root-dir=false
          env:
            - name: CSI_ENDPOINT
              value: unix:///var/lib/csi/sockets/pluginproxy/csi.sock
            - name: CSI_NODE_NAME
              valueFrom:
                fieldRef:
                  fieldPath: spec.nodeName
          volumeMounts:
            - name: socket-dir
              mountPath: /var/lib/csi/sockets/pluginproxy/
          ports:
            - name: healthz
              containerPort: 9909
              protocol: TCP
          livenessProbe:
            httpGet:
              path: /healthz
              port: healthz
            initialDelaySeconds: 10
            timeoutSeconds: 3
            periodSeconds: 10
            failureThreshold: 5
        - name: csi-provisioner
          image: public.ecr.aws/eks-distro/kubernetes-csi/external-provisioner:v5.0.1-eks-1-30-8
          imagePullPolicy: IfNotPresent
          args:
            - --csi-address=$(ADDRESS)
            - --v=2
            - --feature-gates=Topology=true
            - --extra-create-metadata
            - --leader-election
            - --leader-election-renew-deadline=10s
            - --leader-election-lease-duration=15s
          env:
            - name: ADDRESS
              value: /var/lib/csi/sockets/pluginproxy/csi.sock
          volumeMounts:
            - name: socket-dir
              mountPath: /var/lib/csi/sockets/pluginproxy/
          securityContext:
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: true
        - name: liveness-probe
          image: public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe:v2.13.0-eks-1-30-8
          imagePullPolicy: IfNotPresent
          args:
            - --csi-address=/csi/csi.sock
            - --health-port=9909
          volumeMounts:
            - name: socket-dir
              mountPath: /csi
          securityContext:
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: true
      volumes:
        - name: socket-dir
          emptyDir: {}
---
# Source: aws-efs-csi-driver/templates/csidriver.yaml
apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
  name: efs.csi.aws.com
  annotations:
    "helm.sh/hook": pre-install, pre-upgrade
    "helm.sh/hook-delete-policy": before-hook-creation
    "helm.sh/resource-policy": keep
spec:
  attachRequired: false

ghost · 2024-07-18T08:41:53Z

Hi!
I was also waiting for this feature and happy to see the PR!
@d-nishi @mskanth972 , sorry to bother you, but would you be able to review it so that it will be merged and not forgotten as previous PR please?

mkilchhofer

LGTM.
I also place myself in the waiting queue :)

sherifabdlnaby · 2024-11-25T20:54:42Z

Hey team! PDB is very important configuration to have exposed by the chart! Can we get this merged ? I think this PR just needs a rebase and should be good to be merged. Unfortunately I can't rebase it myself.

@omerap12 Can you rebase and lets work on getting this merged ? 🙏🏻

mskanth972 · 2024-11-25T20:58:01Z

I can help in merge, @omerap12 can you you rebase it?

sherifabdlnaby · 2024-11-25T20:58:31Z

@d-nishi @mskanth972 Sorry to bother guys! Will appreciate if we can get this merged 🙏🏻 It is backward compatible and should be OK to merge IMO 🙏🏻

omerap12 · 2024-11-26T05:40:12Z

I can help in merge, @omerap12 can you you rebase it?

Sure. Ill merge it today

deepak-kosaraju · 2024-11-26T06:39:32Z

charts/aws-efs-csi-driver/templates/controller-pdb.yaml

@@ -0,0 +1,19 @@
+{{- if .Values.controller.pdb }}


@omerap12 - As most of community controllers use podDisruptionBudget instead of pdb, can we use the same standard for consistency?

example: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/templates/poddisruptionbudget-controller.yaml

Should we also set defaults for minAvailable and maxUnavailable similar to how its set in ebs controller?

Good idea. Ill adjust.

deepak-kosaraju · 2024-11-26T06:43:45Z

charts/aws-efs-csi-driver/values.yaml

@@ -101,6 +103,8 @@ controller:
    #  eks.amazonaws.com/role-arn: arn:aws:iam::111122223333:role/efs-csi-role
  healthPort: 9909
  regionalStsEndpoints: false
+  # Pod Disruption Budget
+  pdb: {}


@omerap12 - What about enabling this as default from the chart similar to ebs controller, unless we like to keep it backward compatible and not surprisingly have it enabled.
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/50f6b2e68446b221bde01fbd3aca190ea9a0e569/charts/aws-ebs-csi-driver/values.yaml#L250-L254

Currently, this feature doesn't exist. In my opinion, it would be best to disable it by default and only enable it by default once it is well-received by the users.

deepak-kosaraju · 2024-11-26T06:51:08Z

I can help in merge, @omerap12 can you you rebase it?

Sure. Ill merge it today

I don't think you can merge it after rebase based on the @k8s-ci-robot comment above,

Once this PR has been reviewed and has the lgtm label, please assign mskanth972 for approval. For more information see the Kubernetes Code Review Process

omerap12 · 2024-11-26T06:53:13Z

I can help in merge, @omerap12 can you you rebase it?

Sure. Ill merge it today

I don't think you can merge it after rebase based on the @k8s-ci-robot comment above,

Once this PR has been reviewed and has the lgtm label, please assign mskanth972 for approval. For more information see the Kubernetes Code Review Process

Yes, that what I meant :)

deepak-kosaraju · 2024-11-26T07:02:28Z

@omerap12 - Based of previous release #1433 can you also update update the CHANGELOG and chart version to 3.0.9

omerap12 · 2024-11-26T07:30:21Z

@deepak-kosaraju PTAL

omerap12 · 2024-11-26T07:46:24Z

3.0.9

Are you sure? The chart version is 3.1.1 at the moment..

mskanth972 · 2024-11-26T13:08:55Z

3.0.9

Are you sure? The chart version is 3.1.1 at the moment..

Please remove that, we can add while making a release.

omerap12 · 2024-11-26T15:08:34Z

3.0.9

Are you sure? The chart version is 3.1.1 at the moment..

Please remove that, we can add while making a release.

Done

mskanth972 · 2024-11-26T15:10:22Z

3.0.9

Are you sure? The chart version is 3.1.1 at the moment..

Please remove that, we can add while making a release.

Done

Sorry, can you please squash all the commits to one.

omerap12 · 2024-11-26T15:15:24Z

3.0.9

Are you sure? The chart version is 3.1.1 at the moment..

Please remove that, we can add while making a release.

Done

Sorry, can you please squash all the commits to one.

Done

mskanth972 · 2024-11-26T15:17:34Z

/lgtm
/approve

omerap12 · 2024-11-26T15:19:22Z

/lgtm /approve

Thanks! by the way I have this PR ( from long time ago ): #1351
Do we wish to merge it as well? or should I close it?

sherifabdlnaby · 2024-11-26T15:19:43Z

Please check my comments before merging :)

charts/aws-efs-csi-driver/templates/controller-pdb.yaml

charts/aws-efs-csi-driver/values.yaml

mskanth972 · 2024-11-26T15:21:23Z

/hold

commit 2dfd178 Author: Omer Aplatony <[email protected]> Date: Tue Nov 26 17:07:14 2024 +0200 revert Signed-off-by: Omer Aplatony <[email protected]> commit 3b7dbbd Author: Omer Aplatony <[email protected]> Date: Tue Nov 26 09:16:04 2024 +0200 Set default values Signed-off-by: Omer Aplatony <[email protected]> commit 508e32a Merge: a943df0 c963295 Author: Omer Aplatony <[email protected]> Date: Tue Nov 26 09:04:32 2024 +0200 Merged master Signed-off-by: Omer Aplatony <[email protected]> commit a943df0 Author: Omer Aplatony <[email protected]> Date: Sun Jul 7 10:06:27 2024 +0300 Add Pod Disruption Budget and configurable deployment name Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Omer Aplatony <[email protected]> Apply suggestions from code review Co-authored-by: Sherif Abdel-Naby <[email protected]> Signed-off-by: Omer Aplatony <[email protected]>

omerap12 · 2024-11-26T15:24:31Z

PTAL @sherifabdlnaby

k8s-ci-robot · 2024-11-26T15:31:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkilchhofer, mskanth972, omerap12, sherifabdlnaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mskanth972]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

omerap12 · 2024-11-26T15:39:26Z

ping @mskanth972

mskanth972 · 2024-11-26T15:40:42Z

/unhold

mskanth972 · 2024-11-26T16:48:18Z

/lgtm

deepak-kosaraju · 2024-11-26T16:57:14Z

@mskanth972 and @omerap12
Template need fix for copy/paste error,
aws-ebs-csi-driver.labels should be aws-efs-csi-driver.labels
ref: https://github.com/omerap12/aws-efs-csi-driver/blob/92fdf69a7d8a2717155cc65177395af378882241/charts/aws-efs-csi-driver/templates/_helpers.tpl#L37

I was about to submit review comment, and noticed its merged so added this comment.

omerap12 · 2024-11-26T17:00:59Z

@mskanth972 and @omerap12 Template need fix for copy/paste error, aws-ebs-csi-driver.labels should be aws-efs-csi-driver.labels ref: https://github.com/omerap12/aws-efs-csi-driver/blob/92fdf69a7d8a2717155cc65177395af378882241/charts/aws-efs-csi-driver/templates/_helpers.tpl#L37

I was about to submit review comment, and noticed its merged so added this comment.

#1510

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2024

k8s-ci-robot requested review from d-nishi and mskanth972 July 7, 2024 07:16

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2024

mkilchhofer approved these changes Aug 26, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2024

sherifabdlnaby mentioned this pull request Nov 25, 2024

Pod disruption budget #1397

Closed

sherifabdlnaby approved these changes Nov 25, 2024

View reviewed changes

deepak-kosaraju reviewed Nov 26, 2024

View reviewed changes

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2024

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024

omerap12 requested review from sherifabdlnaby, mkilchhofer and deepak-kosaraju November 26, 2024 07:30

omerap12 force-pushed the issue_1397 branch from 2dfd178 to 22bf4fe Compare November 26, 2024 15:15

k8s-ci-robot assigned mskanth972 Nov 26, 2024

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2024

sherifabdlnaby suggested changes Nov 26, 2024

View reviewed changes

charts/aws-efs-csi-driver/templates/controller-pdb.yaml Outdated Show resolved Hide resolved

charts/aws-efs-csi-driver/values.yaml Outdated Show resolved Hide resolved

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 26, 2024

omerap12 force-pushed the issue_1397 branch from 91e6b80 to 92fdf69 Compare November 26, 2024 15:24

sherifabdlnaby approved these changes Nov 26, 2024

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024

k8s-ci-robot merged commit e6a3ab9 into kubernetes-sigs:master Nov 26, 2024
8 checks passed

z0rc mentioned this pull request Dec 9, 2024

Fix default value for unhealthyPodEvictionPolicy #1524

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Pod Disruption Budget and configurable deployment name #1404

Add Pod Disruption Budget and configurable deployment name #1404

omerap12 commented Jul 7, 2024

ghost commented Jul 18, 2024

mkilchhofer left a comment

sherifabdlnaby commented Nov 25, 2024 •

edited

Loading

mskanth972 commented Nov 25, 2024

sherifabdlnaby commented Nov 25, 2024

omerap12 commented Nov 26, 2024

deepak-kosaraju Nov 26, 2024 •

edited

Loading

omerap12 Nov 26, 2024

deepak-kosaraju Nov 26, 2024 •

edited

Loading

omerap12 Nov 26, 2024

deepak-kosaraju commented Nov 26, 2024

omerap12 commented Nov 26, 2024

deepak-kosaraju commented Nov 26, 2024

omerap12 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024 •

edited

Loading

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

sherifabdlnaby commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

k8s-ci-robot commented Nov 26, 2024

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

deepak-kosaraju commented Nov 26, 2024 •

edited

Loading

omerap12 commented Nov 26, 2024

Add Pod Disruption Budget and configurable deployment name #1404

Add Pod Disruption Budget and configurable deployment name #1404

Conversation

omerap12 commented Jul 7, 2024

ghost commented Jul 18, 2024

mkilchhofer left a comment

Choose a reason for hiding this comment

sherifabdlnaby commented Nov 25, 2024 • edited Loading

mskanth972 commented Nov 25, 2024

sherifabdlnaby commented Nov 25, 2024

omerap12 commented Nov 26, 2024

deepak-kosaraju Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

omerap12 Nov 26, 2024

Choose a reason for hiding this comment

deepak-kosaraju Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

omerap12 Nov 26, 2024

Choose a reason for hiding this comment

deepak-kosaraju commented Nov 26, 2024

omerap12 commented Nov 26, 2024

deepak-kosaraju commented Nov 26, 2024

omerap12 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024 • edited Loading

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

sherifabdlnaby commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

omerap12 commented Nov 26, 2024

k8s-ci-robot commented Nov 26, 2024

omerap12 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

mskanth972 commented Nov 26, 2024

deepak-kosaraju commented Nov 26, 2024 • edited Loading

omerap12 commented Nov 26, 2024

sherifabdlnaby commented Nov 25, 2024 •

edited

Loading

deepak-kosaraju Nov 26, 2024 •

edited

Loading

deepak-kosaraju Nov 26, 2024 •

edited

Loading

mskanth972 commented Nov 26, 2024 •

edited

Loading

deepak-kosaraju commented Nov 26, 2024 •

edited

Loading