Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve large size volume cloning e2e test #1521

Merged
merged 1 commit into from
Nov 7, 2023
Merged

test: improve large size volume cloning e2e test #1521

merged 1 commit into from
Nov 7, 2023

Conversation

umagnus
Copy link
Contributor

@umagnus umagnus commented Oct 19, 2023

What type of PR is this?

/kind test

What this PR does / why we need it:

test: improve large size volume cloning e2e test

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

large size volume cloning e2e test is not stable because of dd command to create a 99G size file, use head command to improve it
Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: umagnus
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andyzhangx
andyzhangx reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2023
@andyzhangx
Copy link
Member

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Oct 19, 2023
@andyzhangx
Copy link
Member

/retest

@umagnus umagnus force-pushed the improve_volumecloning_e2e branch from a12d479 to 1e29ca9 Compare October 19, 2023 06:45
@andyzhangx
Copy link
Member

/retest

3 similar comments
@umagnus
Copy link
Contributor Author

umagnus commented Oct 20, 2023

/retest

@andyzhangx
Copy link
Member

/retest

@umagnus
Copy link
Contributor Author

umagnus commented Oct 25, 2023

/retest

@umagnus umagnus force-pushed the improve_volumecloning_e2e branch from 1e29ca9 to 5546cf3 Compare October 26, 2023 03:32
@umagnus
Copy link
Contributor Author

umagnus commented Oct 27, 2023

/retest

@umagnus umagnus force-pushed the improve_volumecloning_e2e branch from 5546cf3 to 751f55a Compare November 2, 2023 08:34
@umagnus
Copy link
Contributor Author

umagnus commented Nov 3, 2023

/retest

1 similar comment
@umagnus
Copy link
Contributor Author

umagnus commented Nov 3, 2023

/retest

@umagnus umagnus force-pushed the improve_volumecloning_e2e branch from 751f55a to 0a94ce2 Compare November 6, 2023 02:05
@umagnus
Copy link
Contributor Author

umagnus commented Nov 6, 2023

/retest

1 similar comment
@umagnus
Copy link
Contributor Author

umagnus commented Nov 6, 2023

/retest

@andyzhangx andyzhangx merged commit f88d867 into kubernetes-sigs:master Nov 7, 2023
10 checks passed
@umagnus umagnus deleted the improve_volumecloning_e2e branch June 20, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx left review comments

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/test ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umagnus @k8s-ci-robot @andyzhangx