-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refine UT for ListenEndpoint in utils.go #2340
Conversation
Hi @Zhupku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
1 similar comment
/retest |
@Zhupku: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Zhupku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request focuses on improving error handling in the
pkg/csi-common/utils.go
file by replacing calls toklog.Fatalf
withklog.Errorf
, and updating the associated test cases accordingly. The most important changes include the removal of theklogFatalf
function, the modification of error logging in theListenEndpoint
function, and the simplification of theTestListenEndpoint
test cases.Improvements to error handling:
pkg/csi-common/utils.go
: Removed theklogFatalf
function and replaced calls to it withklog.Errorf
in theListenEndpoint
function to avoid terminating the program on errors. [1] [2]Updates to test cases:
pkg/csi-common/utils_test.go
: Simplified theTestListenEndpoint
function by removing the override ofklogFatalf
and the associated deferred function for recovering from panics, as the program no longer terminates on errors. [1] [2]<!-- Thanks for sending a pull request! Here are some tips for you:https://git.k8s.io/community/contributors/devel/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: