Skip to content

test: add ut for encryptInTransitField#2533

Closed
cvvz wants to merge 4 commits intokubernetes-sigs:masterfrom
cvvz:ut-for-encryptInTransitField
Closed

test: add ut for encryptInTransitField#2533
cvvz wants to merge 4 commits intokubernetes-sigs:masterfrom
cvvz:ut-for-encryptInTransitField

Conversation

@cvvz
Copy link
Copy Markdown
Member

@cvvz cvvz commented Apr 22, 2025

What type of PR is this?
/kind test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cvvz
Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2025
mountPermissionsField: "0755",
accountQuotaField: "1000",
useDataPlaneAPIField: "oauth",
encryptInTransitField: "true",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add a negative case?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@cvvz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-unit 2339bd1 link true /test pull-azurefile-csi-driver-unit
pull-azurefile-csi-driver-verify 2339bd1 link true /test pull-azurefile-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cvvz cvvz closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants