🐛 Ignore informer sync error #5200
Conversation
Signed-off-by: Aniruddha Basak <[email protected]>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
/cc @richardcase |
| @@ -124,7 +125,9 @@ func (s *Service) getRolesForMachineDeployments(ctx context.Context, allRoles ma | |||
| } | |||
| err := s.client.List(ctx, deploymentList, selectors...) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to list machine deployments for cluster %s/%s: %w", s.scope.Namespace(), s.scope.Name(), err) | |||
| if !containsTimeoutSyncError(err) { | |||
There was a problem hiding this comment.
I'm not convinced that this is the solution to the issue.
It would be good to understand by the informer isn't synced. Do we need to introduce changes to the Cache settings for the manager? Would indexers help?
|
Whilst discussions are on going: /hold |
k8s-ci-robot
added
the
do-not-merge/hold
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5128
Special notes for your reviewer:
Checklist:
Release note: