-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Peer AKS VNet (mgmt) with VM based default templates #5288
base: main
Are you sure you want to change the base?
[WIP] Peer AKS VNet (mgmt) with VM based default templates #5288
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d24a789
to
dd27c47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5288 +/- ##
==========================================
+ Coverage 52.52% 52.57% +0.04%
==========================================
Files 272 272
Lines 29433 29408 -25
==========================================
+ Hits 15461 15462 +1
+ Misses 13169 13148 -21
+ Partials 803 798 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
a137743
to
cbba70f
Compare
- update aks-as-mgmt scripts with VNet creation and all clusters deletion - update default template - update default aad - update azure-bastion templates - update azure-cni-v1 templates - update edgezone templates - update ephemeral templates - update private templates - update flatcar templates - update nvdia-gpu templates
cbba70f
to
3025950
Compare
if settings.get("container_args"): | ||
capz_container_args = settings.get("container_args").get("capz-controller-manager") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have often struggled in getting more logs outputted while running in tilt.
With this change, if we add the below yaml fields to our tilt-settings.yaml, we will can play around with more logging
container_args:
capz-controller-manager:
- "--v=2"
link checker is complaining about a deprecated module. Will follow up with another PR to fix it.
Unrelated, but this PR seems to be blocked on Windows conformance jobs. |
/retest |
this PR needs to be held for feature flag for ILB can be added. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # #5261
Special notes for your reviewer:
TODOs:
Release note: