-
Notifications
You must be signed in to change notification settings - Fork 458
[release-1.20] Define NoSchedule tolerations for tigera-operator #5890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.20] Define NoSchedule tolerations for tigera-operator #5890
Conversation
# when it continuously gets scheduled onto an out-of-date Node that is being | ||
# deleted. Tolerate only the NoSchedule taints that are expected. | ||
tolerations: | ||
- effect: NoExecute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would have been better asked in the original PR, but should we add a comment describing why we want to tolerate all NoExecute taints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That toleration was already set by default, so I was only trying to change as few things as possible to get around the flake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a bug in the comment
By default, tigera tolerates all NoSchedule taints
should it be
By default, tigera tolerates all NoExecute taints
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are true. I was trying to call out the delta between what tigera sets by default and what we need to change it to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good talk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.20 #5890 +/- ##
================================================
- Coverage 52.81% 52.80% -0.01%
================================================
Files 279 279
Lines 29602 29602
================================================
- Hits 15634 15632 -2
- Misses 13154 13156 +2
Partials 814 814 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/lgtm |
LGTM label has been added. Git tree hash: a6ca95b963978bb3d8bc7430cf8f6b1c12d659f7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind flake
What this PR does / why we need it:
Manual cherry-pick of #5704:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Ref #5703
Special notes for your reviewer:
TODOs:
Release note: