Skip to content

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 1, 2025

What type of PR is this?
/kind flake

What this PR does / why we need it:

Manual cherry-pick of #5704:

This PR changes the tigera-operator Pod to tolerate only the NoSchedule tolerations that are set when a Node is being bootstrapped instead of all of them (which includes the node.kubernetes.io/unschedulable taint set when a Node is cordoned and drained).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Ref #5703

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 1, 2025
# when it continuously gets scheduled onto an out-of-date Node that is being
# deleted. Tolerate only the NoSchedule taints that are expected.
tolerations:
- effect: NoExecute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would have been better asked in the original PR, but should we add a comment describing why we want to tolerate all NoExecute taints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That toleration was already set by default, so I was only trying to change as few things as possible to get around the flake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a bug in the comment

By default, tigera tolerates all NoSchedule taints

should it be

By default, tigera tolerates all NoExecute taints

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are true. I was trying to call out the delta between what tigera sets by default and what we need to change it to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good talk

Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.80%. Comparing base (58587ac) to head (f96822a).
⚠️ Report is 3 commits behind head on release-1.20.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.20    #5890      +/-   ##
================================================
- Coverage         52.81%   52.80%   -0.01%     
================================================
  Files               279      279              
  Lines             29602    29602              
================================================
- Hits              15634    15632       -2     
- Misses            13154    13156       +2     
  Partials            814      814              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jackfrancis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6ca95b963978bb3d8bc7430cf8f6b1c12d659f7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 1, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2c0cd92 into kubernetes-sigs:release-1.20 Oct 1, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Oct 1, 2025
@nojnhuh nojnhuh deleted the tigera-tolerations branch October 1, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants