CI: check if PowerVS instances are cleaned up in workspace before creating a cluster #2001
Conversation
k8s-ci-robot
added
the
area/provider/ibmcloud
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Amulyam24 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/L
|
Also needs changes to the job - ppc64le-cloud/test-infra#488 |
|
/cc @Karthik-K-N |
| // CheckPowerVSInstances verifies if the Powervs instances are deleted | ||
| // before proceeding with the next cluster creation. | ||
| func CheckPowerVSInstances(serviceInstanceID string) error { | ||
| pclient, err := getPowerVSInstanceClient(serviceInstanceID) |
There was a problem hiding this comment.
For my better understanding, since we are trying to check all the VMs under this service instance is being deleted, So there wont be two jobs running at any time right, Because in case other will be creating and we are waiting for it be deleted?
|
|
||
| // CheckPowerVSInstances verifies if the Powervs instances are deleted | ||
| // before proceeding with the next cluster creation. | ||
| func CheckPowerVSInstances(serviceInstanceID string) error { |
There was a problem hiding this comment.
Just a thought, it can be this anyway, If possible its better to rename this function because i think
- PowerVSInstances can be PowerVS server instance or service instance, Here we are looking for server instances(VM).
- We are only checking for deleting state, may be some name related to delete would directly indicate the purpose of function.
What this PR does / why we need it:
In PowerVS CI, we have seen a case where after the first test case, the VMs deletion is in progress and we proceed to create the second cluster. It leads to the error
Adding this change to check if the instances are deleted before each cluster creation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1877
Special notes for your reviewer:
/area provider/ibmcloud
Release note: