-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump CAPI to v1.9.0-beta.1 #2251
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold |
The tests fail because kubernetes-sigs/cluster-api#11317 which deprecates @lentzi90 @mdbooth we should get rid of the |
I think it depends on how much work it would be to switch. If we can do that pretty easily, let's just get it done. Otherwise, let's ignore the deprecation warning and give ourselves more time to work on it in the mean time. |
640d8f3
to
b84016a
Compare
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Context: kubernetes-sigs/cluster-api#10784 We'll maintain them here for the time being, until we have conditions replacing these errors.
b84016a
to
fa6367c
Compare
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Do we want to take this in already or wait for the final release?
One thing I am wondering about is also how the FailureMessage will now work. Previously, CAPI would propagate them up to the CAPI objects, but I'm guessing that would no longer happen in v1.9. That would mean that it is harder for users to detect when something is wrong.
If that it the case, should we rather hold off on this until we can transition to conditions instead?
Yeah, that's a good point. I'm personally convinced that we will not release 0.12 until we get these conditions addressed, so we can probably live without the CAPO failures propagated to the CAPI objects. |
Yeah I agree it is good to bump early and test it out properly. Shouldn't be a big deal to switch to conditions either. |
What this PR does / why we need it:
Bump to the latest CAPI:
go.mod
with the new tag.make modules
in root andorc/
.make generate
.Issue #2259