Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage of ClusterCacheTracker #9044

Closed
sbueringer opened this issue Jul 21, 2023 · 5 comments
Closed

Improve test coverage of ClusterCacheTracker #9044

sbueringer opened this issue Jul 21, 2023 · 5 comments
Assignees
@sbueringer
Labels
area/clustercachetracker Issues or PRs related to the clustercachetracker help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

ClusterCacheTracker is a crucial component in Cluster API as it's used across controllers to communicate with workload clusters.

We had a few bugs in edge cases:

I think we should take a look at these issues again and audit the entire code to ensure we have test coverage for all relevant cases. Including edge cases with unreachable workload cluster apiservers.

One of the problems that can occur when workload cluster apiservers become unreachable is that Reconcilers are getting stuck. So it's important to avoid bugs in CCT.
@sbueringer sbueringer added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 21, 2023
@killianmuldoon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 21, 2023
@fabriziopandini
Copy link
Member

/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 11, 2024
@fabriziopandini fabriziopandini added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 6, 2024
@sbueringer
Copy link
Member Author

/assign

@sbueringer sbueringer mentioned this issue Oct 2, 2024
Merged
@sbueringer
Copy link
Member Author

/close

in favor of #11272

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

/close

in favor of #11272

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbueringer sbueringer

Labels
area/clustercachetracker Issues or PRs related to the clustercachetracker help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon