Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce new ClusterCache #11247

Merged
merged 1 commit into from
Oct 15, 2024
Merged

✨ Introduce new ClusterCache #11247

merged 1 commit into from
Oct 15, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 1, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11272

@sbueringer sbueringer added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 1, 2024
@sbueringer sbueringer changed the title [WIP][DONT Review] ✨ Introduce new ClusterCache [WIP]✨ [DONT Review] Introduce new ClusterCache Oct 1, 2024
@sbueringer sbueringer force-pushed the pr-cct-refactoring branch 2 times, most recently from d6bb5d9 to fd16439 Compare October 1, 2024 19:45
fabriziopandini
fabriziopandini reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Made a first pass on the clustercache package only

controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-cct-refactoring branch 8 times, most recently from 5399eea to e07ac8b Compare October 8, 2024 15:10
@sbueringer sbueringer changed the title [WIP]✨ [DONT Review] Introduce new ClusterCache ✨ Introduce new ClusterCache Oct 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@sbueringer sbueringer mentioned this pull request Oct 8, 2024
Open
12 tasks
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

sbueringer commented Oct 8, 2024 •
edited
Loading

Rebased to resolve a conflict with: #11252

@fabriziopandini fabriziopandini mentioned this pull request Oct 8, 2024
Closed
59 tasks
chrischdi
chrischdi reviewed Oct 9, 2024
View reviewed changes
internal/controllers/cluster/cluster_controller.go Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/doc.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_accessor.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor_client.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_accessor_client.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_accessor_client.go Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of nits from my side, great job!

api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
internal/test/envtest/environment.go Show resolved Hide resolved
util/util.go Show resolved Hide resolved
internal/controllers/cluster/cluster_controller.go Show resolved Hide resolved
controllers/clustercache/doc.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor_test.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor_test.go Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
@sbueringer
Copy link
Member Author

Thx for the reviews :)

Findings addressed and/or answered, PTAL

/assign @fabriziopandini @chrischdi @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cef23a3903dbf551d4338946c22a746de665c355

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@sbueringer
Copy link
Member Author

Rebased onto latest main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2094bee751d754f3a10f1bf7ef498e76c6b395f

@vincepri
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

Thx for the reviews. Really appreciate it, I know this wasn't a trivial one to review 😀

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 15, 2024 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 19c80d4 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

A bit ironic. Flake on the old CCT :)

/test pull-cluster-api-test-main

@k8s-ci-robot k8s-ci-robot merged commit 2beebbd into kubernetes-sigs:main Oct 15, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 15, 2024
@sbueringer sbueringer deleted the pr-cct-refactoring branch October 15, 2024 08:45
@sbueringer sbueringer mentioned this pull request Oct 21, 2024
Merged
@Sunnatillo Sunnatillo mentioned this pull request Nov 19, 2024
Closed
54 tasks
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@chrischdi chrischdi Awaiting requested review from chrischdi

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@chrischdi chrischdi

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @fabriziopandini @k8s-ci-robot @chrischdi @vincepri