-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 ✨ 🧑🤝🧑 add proposal for Node Bootstrapping working group #11407
base: main
Are you sure you want to change the base?
📖 ✨ 🧑🤝🧑 add proposal for Node Bootstrapping working group #11407
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @t-lo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
"@elmiko" "@eljohnson92" I took the liberty to add you as co-stakeholders to the WG proposal - IIRC you expressed interest in participating. I hope that's OK? |
49bf126
to
bf5ce21
Compare
22ad278
to
6353aad
Compare
6353aad
to
f61f4ee
Compare
Thank you Johanan, Fabrizio, and Stefan for tuning in! This is immensely helpful. Made a few changes to the proposal; reworked the whole user story part to focus on goals instead of implementations, and rephrased the "problem statement" section a bit to not hint at a solution when describing the issue. Added a new section on stability and compatibility - this really was the proverbial elephant in the room for me since in Flatcar, we put a massive (occasionally painful) focus on never breaking user workloads ever - kudos to Stefan for calling this out. I'll make sure to hold the working group proposals to an equally high standard. I don't think we're quite there yet but we're definitely making progress. Ready for another round of feedback! |
f61f4ee
to
dbc9ed4
Compare
dbc9ed4
to
857dd3d
Compare
@sbueringer , @fabriziopandini what do you think? Could you give it another pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added a few comments.
I will try to come back to this after code freeze next week, I need to focus on stuff to get merged + CI signal and bandwidth is limited 😢 |
Also showing up, I will need some more time to read myself into all of this but my focus now is first the upcoming CAPI release! |
dfbccad
to
1857df2
Compare
Rebased to latest main, squashed to a single commit, and added the meeting cadence and link to the meeting calendar. @schrej could you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 74de9f021d75cde603c0e2f0b71ea274de02f5f5
|
/ok-to-test |
@t-lo the CI doesn't like the link to the calendar file. I wonder if it's OK to ignore this test. |
I'm a bit confused by the problem statement in the document.
I'm trying to figure out if I should be involved at all (right now it seems like the answer is no) because Talos Linux doesn't use ignition, cloud-init, or kubeadm to configure (and re-configure) a node for kubernetes. |
Hey @rothgar. This working group is about improving the separation between bootstrap and provisioning. "Bootstrap" means "turning a server into a k8s node". "Provisioning" means "running cloud-init/Ignition to customize a server". "Server" in this context means a physical bare metal server or a VM. We don't intend to alter the functionality of bootstrap or provisioning in this working group, we're concerned mainly with how we can maintain and evolve multiple provisioner implementations (e.g. cloud-init, Ignition) over time, which hopefully requires only under-the-hood changes with no user impact. This does entail touching CABPK (the kubeadm bootstrap provider) because right now bootstrap and provisioning are tightly coupled, which means we can't touch e.g. cloud-init code without touching kubeadm-related code. We hope to get to an acceptable state in CABPK which could serve as a "template" for other bootstrap providers, however there's still a way to go before we get there. We want to avoid making API changes to the extent that's possible, but of course if we do end up proposing API changes then this would affect all relevant providers, including Talos. I suggest you keep an eye on the products of this working group to determine if/when you need to be involved (we will provide updates in the CAPI office hours so you can watch the notes/recordings), however I think that at the moment this work is irrelevant for anything which doesn't use kubeadm, cloud-init or Ignition. We'll be sure to broadcast any significant changes loudly to the community in case we realize they're inevitable. |
I'd like to keep the iCal link - it's very convenient to be able to import the meeting series. Here's the link, it works: https://calendar.google.com/calendar/ical/90d22cde4972f248d6516a96de05ef62553644fff261e2150f5f229546d59d41%40group.calendar.google.com/public/basic.ics Tested on a number of machines. If we could figure out what makes this test fail then that would be awesome... @rothgar If you like to know more, feel free to join our WG office hours Thursday next week (Dec 19), at 5pm UTC - happy to chat and to give an intro to the whole thing. |
/ok-to-test |
/retest |
77ca5e0
to
536ecda
Compare
/retest |
Co-authored-by: Johanan Liebermann <[email protected]> Co-authored-by: Jakob Schrettenbrunner <[email protected]> Signed-off-by: Thilo Fromm <[email protected]>
536ecda
to
ba7442a
Compare
/lgtm |
LGTM label has been added. Git tree hash: 5aed488f3075793a52ddf47fa7eda64d36334ac0
|
What this PR does / why we need it:
Propose a working group for node bootstrapping and cluster provisioning.
The need for this working group originated from an ongoing discussion around separating cluster provisioning and node bootstrapping, as stated in the WG's User Story.
Which issue(s) this PR fixes
CC
Tags
/area provider/bootstrap-kubeadm
/area bootstrap
/kind documentation
/kind proposal