-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add Infrastructure provider Harvester #11477
base: main
Are you sure you want to change the base?
🌱 Add Infrastructure provider Harvester #11477
Conversation
Signed-off-by: Mohamed Belgaied Hassine <[email protected]>
Welcome @belgaied2! |
Hi @belgaied2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Mohamed Belgaied Hassine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a9f4f1afc884fdd9c5113b5c47d3ad33ab436cfa
|
/ok-to-test |
Hi @chrischdi , I think this PR misses a very slight push forward ;) I would be greatly if you do that push ! |
Co-authored-by: Fabrizio Pandini <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a lint error which needs to be fixed.
Co-authored-by: Christian Schlotter <[email protected]>
Signed-off-by: Mohamed Belgaied Hassine <[email protected]>
@chrischdi Linting issues fixed! :) |
Signed-off-by: Mohamed Belgaied Hassine [email protected]
What this PR does / why we need it:
This PR adds the CAPI Infrastructure provider for Harvester to the
clusterctl
provider list and the docs.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #11476
/area clusterctl
/size M