✨ WIP: Cluster Provider and cluster-aware controllers #2726

sttts · 2024-03-25T09:16:20Z

Replacing #2207.

k8s-ci-robot · 2024-03-25T09:16:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/cluster/cluster.go

mjudeikis

This is way cleaner than previous one. I like it.

pkg/builder/controller.go

pkg/builder/options.go

pkg/builder/controller.go

pkg/config/controller.go

Co-authored-by: Vince Prignano <[email protected]> Signed-off-by: Vince Prignano <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

sbueringer · 2024-04-25T15:22:20Z

pkg/controller/multicluster.go

+		if err := ctrl.Disengage(ctx, cl); err != nil {
+			errs = append(errs, err)
+		}
+	}


Would this also:

loop through c.awares and call Disengage on them

close watches that we opened in Engage

Signed-off-by: Iván Álvarez <[email protected]>

Co-authored-by: Dr. Stefan Schimanski <[email protected]>

Signed-off-by: Iván Álvarez <[email protected]>

…ntroller-runtime into sttts-cluster-support

Signed-off-by: Iván Álvarez <[email protected]>

✨Fleet example changes

linux-foundation-easycla · 2024-05-28T13:06:31Z

✅login: ivanape / (9ce51b8)
✅login: ivanape / (9ce51b8, 86639c0)
✅login: ivanape / (9ce51b8, 86639c0, 2f0deff)
✅login: ivanape / (9ce51b8, 86639c0, 2f0deff, 9391114)
✅login: ivanape / (9ce51b8, 86639c0, 2f0deff, 9391114, a9d3c00)
✅login: sttts / (3811640)
✅login: sttts / (3811640, ad9760b)
✅login: sttts / (3811640, ad9760b, 25734fe)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1, 6db0f6f)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1, 6db0f6f, 5bafe05)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1, 6db0f6f, 5bafe05, fc48477)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1, 6db0f6f, 5bafe05, fc48477, 489224f)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1, 6db0f6f, 5bafe05, fc48477, 489224f, 56e0c2b)
✅login: sttts / (3811640, ad9760b, 25734fe, ca692b1, 6db0f6f, 5bafe05, fc48477, 489224f, 56e0c2b, d51d3e4)

The committers listed above are authorized under a signed CLA.

k8s-ci-robot · 2024-05-28T13:10:11Z

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-controller-runtime-test	`d51d3e4`	link	true	`/test pull-controller-runtime-test`
pull-controller-runtime-apidiff	`d51d3e4`	link	false	`/test pull-controller-runtime-apidiff`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

alvaroaleman · 2024-05-28T13:53:34Z

pkg/reconcile/reconcile.go

+	// ClusterName identifies the cluster that the object is in.
+	// The property is only populated when controllers are setup in a fleet manager.
+	// +optional
+	ClusterName string


I'd like to use #2799 to avoid the need of changing this struct and instead allowing BYO request/workqueue type

k8s-ci-robot · 2024-07-06T23:22:02Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024

k8s-ci-robot requested review from varshaprasad96 and vincepri March 25, 2024 09:16

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 25, 2024

sttts force-pushed the sttts-cluster-support branch from 5f6764a to f8eeaef Compare March 25, 2024 09:23

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024

sttts force-pushed the sttts-cluster-support branch from f8eeaef to 45a18eb Compare March 25, 2024 09:24

mjudeikis reviewed Mar 25, 2024

View reviewed changes

pkg/cluster/cluster.go Outdated Show resolved Hide resolved

mjudeikis reviewed Mar 25, 2024

View reviewed changes

pkg/builder/controller.go Outdated Show resolved Hide resolved

pkg/builder/options.go Outdated Show resolved Hide resolved

sttts force-pushed the sttts-cluster-support branch 2 times, most recently from b4891b8 to 45b458a Compare March 25, 2024 13:32

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024

sttts force-pushed the sttts-cluster-support branch 3 times, most recently from b44fd93 to 980095c Compare March 26, 2024 10:28

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024

sttts force-pushed the sttts-cluster-support branch 2 times, most recently from e471049 to d023d3e Compare March 31, 2024 13:38

sttts mentioned this pull request Mar 31, 2024

📖 Add designs/multi-cluster.md #2746

Open

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024

sbueringer reviewed Apr 11, 2024

View reviewed changes

pkg/builder/controller.go Outdated Show resolved Hide resolved

pkg/config/controller.go Outdated Show resolved Hide resolved

sttts force-pushed the sttts-cluster-support branch from 4d8e79e to 307ec8f Compare April 23, 2024 12:29

✨ Cluster Provider and cluster-aware controllers

3811640

Co-authored-by: Vince Prignano <[email protected]> Signed-off-by: Vince Prignano <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>

sttts force-pushed the sttts-cluster-support branch from 307ec8f to 3811640 Compare April 23, 2024 14:01

sttts changed the title ~~WIP: Cluster Provider and cluster-aware controllers~~ ✨ WIP: Cluster Provider and cluster-aware controllers Apr 23, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024

SQUASH: fixes

ad9760b

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

sttts added 2 commits April 23, 2024 19:00

SQUASH: fixes

25734fe

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

SQUASH: get rid of unused ByNameGetterFunc

ca692b1

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024

sttts added 5 commits April 24, 2024 12:01

SQUASH: Allow raw source

6db0f6f

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

SQUASH: cluster.{AwareRunnable -> Aware}

5bafe05

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

SQUASH: better disengage error behaviour

fc48477

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

SQUASH: add ClusterAwareSource

489224f

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

SQUASH: make manager cluster.Aware

56e0c2b

Signed-off-by: Dr. Stefan Schimanski <[email protected]>

sbueringer reviewed Apr 25, 2024

View reviewed changes

sttts mentioned this pull request Apr 30, 2024

✨ Prepare context with cluster kcp-dev/controller-runtime#55

Closed

Fleet example changes

9ce51b8

Signed-off-by: Iván Álvarez <[email protected]>

ivanape mentioned this pull request May 24, 2024

✨Fleet example changes sttts/controller-runtime#1

Merged

ivanape and others added 5 commits May 27, 2024 08:33

Update examples/fleet/main.go

86639c0

Co-authored-by: Dr. Stefan Schimanski <[email protected]>

PR suggested changes

2f0deff

Signed-off-by: Iván Álvarez <[email protected]>

Merge branch 'sttts-cluster-support' of https://github.com/ivanape/co…

9391114

…ntroller-runtime into sttts-cluster-support

Fix fleet example

a9d3c00

Signed-off-by: Iván Álvarez <[email protected]>

Merge pull request #1 from ivanape/sttts-cluster-support

d51d3e4

✨Fleet example changes

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2024

alvaroaleman reviewed May 28, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ WIP: Cluster Provider and cluster-aware controllers #2726

✨ WIP: Cluster Provider and cluster-aware controllers #2726

sttts commented Mar 25, 2024

k8s-ci-robot commented Mar 25, 2024

mjudeikis left a comment

sbueringer Apr 25, 2024

linux-foundation-easycla bot commented May 28, 2024 •

edited

Loading

k8s-ci-robot commented May 28, 2024

alvaroaleman May 28, 2024

k8s-ci-robot commented Jul 6, 2024

✨ WIP: Cluster Provider and cluster-aware controllers #2726

Are you sure you want to change the base?

✨ WIP: Cluster Provider and cluster-aware controllers #2726

Conversation

sttts commented Mar 25, 2024

k8s-ci-robot commented Mar 25, 2024

mjudeikis left a comment

Choose a reason for hiding this comment

sbueringer Apr 25, 2024

Choose a reason for hiding this comment

linux-foundation-easycla bot commented May 28, 2024 • edited Loading

k8s-ci-robot commented May 28, 2024

alvaroaleman May 28, 2024

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 6, 2024

linux-foundation-easycla bot commented May 28, 2024 •

edited

Loading