[release-0.19] ✨ Add EnableWatchBookmarks option to cache informers #3018
+76
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllowWatchBookmarks is generally pretty safe to enable as it has been available in Kuberentes for a long while, and the server ignores the flag if it doesn't implement it (per docs). Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
pkg/cache/cache.go
Outdated
| @@ -398,6 +430,7 @@ func newCache(restConfig *rest.Config, opts Options) newCacheFunc { | |||
| Transform: config.Transform, | |||
| WatchErrorHandler: opts.DefaultWatchErrorHandler, | |||
| UnsafeDisableDeepCopy: ptr.Deref(config.UnsafeDisableDeepCopy, false), | |||
| EnableWatchBookmarks: ptr.Deref(config.EnableWatchBookmarks, true), | |||
There was a problem hiding this comment.
need to change the default
/hold
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b1a07faf97e73b4263437f890c8cabd7ee0fd374
|
k8s-ci-robot
added
the
approved
alvaroaleman
added
tide/merge-method-squash
vincepri
added
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3017
/assign vincepri