Skip to content

Conversation

@veepeeaee
Copy link

PR to add functionality requested in #20

In addition to existing checks, makes adding exclusiveMinimum: true to a minimum clause a breaking change

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: veepeeaee
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2025
Comment on lines +108 to +110
if !a.ExclusiveMinimum && b.ExclusiveMinimum {
errs = append(errs, ErrExclusiveMinimumAdded)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While setting exclusiveMinimum and minimum are pretty tightly coupled, I think this would make more sense to be an entirely separate check than integrated as part of the minimum check.

I've historically tried to separate each of these validations to check a singular schema property to keep scope as small as possible until we explicitly need to start coupling checks together to unlock more advanced use cases. Keeping to that pattern for now would be my preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants