-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add F5 Networks VirtualServer source #3162
Add F5 Networks VirtualServer source #3162
Conversation
@mikejoh I can't review your actual code here but as the Helm chart maintainer could I request that you remove the chart changes from this PR and submit them once the new source has been merged? The binary and Helm release lifecycles aren't aligned so it doesn't make sense having them in a single PR. |
f0fe2a8
to
1e9ebfa
Compare
Check! Fixed here: 7f3c4ed. I'll create a new PR when this one is merged. |
/retest |
@mikejoh: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@stevehipwell Do you have any idea what's going on with those failing tests in the Cloudflare provider? Might be a regression bug? Issue: #3179 |
@mikejoh sorry I don't know. You could push a minor change (e.g. |
@stevehipwell Great, thanks, good to know! 👍🏻 I'll wait a while until the tests are fixed. |
/retest |
7f3c4ed
to
fb3a386
Compare
@seanmalloy Hi! 👋, would it be possible for someone to take a look at this PR? I can understand, by looking at the amount of PRs and issues, that all maintainers here have a lot to do! |
df9591d
to
2dccc66
Compare
df9591d
to
91416e3
Compare
cda6b20
to
7a6e2c7
Compare
7a6e2c7
to
b9ee88d
Compare
@szuecs Hi! 👋, would it be possible to take a look at this PR? I've understood that a lot of work is going into the plugin provider and that reviewing PRs adding/changing providers has been postponed. How is it with PRs and code touching Thanks! |
Would love to have this PR merged. |
Thanks for the pr but we won't review no merge any new providers. Providers will be enabled to use a webhook. Pleas check #3063 , you can adapt your code to integrate with this interface and it will work. |
@szuecs This PR "only" touches the |
@mikejoh yeah true I see it now. Sorry I did not check the source yet. |
b9ee88d
to
9a76be0
Compare
Can this be merged? This would be really useful to have |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikejoh, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
This PR adds support for the F5 Networks
VirtualServer
CRD as a source of creating endpoints.Partly fixes #2739 since this PR adds support for only the
VirtualServer
CRD and not theTransportServer
one. I believe it make sense to keep these separated in terms of PRs.Checklist