fix(chart): allows to read ingress with istio source

[joekhoobyar]

Description

Fixes the use of the external-dns.alpha.kubernetes.io/ingress annotation when only istio resources are enabled as sources.

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevehipwell for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @joekhoobyar!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @joekhoobyar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stevehipwell]

@joekhoobyar is there an issue to track this? I can't see external-dns.alpha.kubernetes.io/ingress in the docs and I need to see more context for why this is needed.

[stevehipwell]

FYI @joekhoobyar while this is being addressed you can use the rbac.additionalPermissions value to manually customise the cluster role.

[joekhoobyar]

FYI @joekhoobyar while this is being addressed you can use the rbac.additionalPermissions value to manually customise the cluster role.

Yes - we did workaround it in that way.

[mloiseleur]

@stevehipwell It's required in the code of the source, see here for istio gateway and here for istio virtual service
/lgtm
/assign @stevehipwell

[mloiseleur]

@joekhoobyar you'll need to update the changelog, too. See other PR on the chart if needed.
/retitle fix(chart): allows to read ingress with istio source